Repository navigation
Conversation
session() assigned its generator to store.generate, so with one store passed to several middlewares every request got the last middleware's genid and cookie options, including on req.session.regenerate(). fixes expressjs#521
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #521.
When one store is passed to two
session()middlewares, every request uses the options of the middleware registered last: itsgenid, cookie options andtrust proxysetting. This also applies onreq.session.regenerate().Root cause:
session()assigns its generator tostore.generate, so the last middleware to be created overwrites it for every middleware sharing that store.Store.prototype.regeneratecallsthis.generate(req)too.Fix: each middleware keeps its own
generateSession. It records that function on the request in a non-enumerable property, next toreq.sessionStore.store.generate(req)then calls the generator recorded on the request, and falls back to the last-created one as before. So a single-middleware app behaves the same, and so does code that callsstore.generatedirectly. Stores that inheritStore.prototype.regenerateget the right generator with no change.Tests: two cases under
genid option, "when the store is shared". One checks the initial id and cookie, the other checksregenerate(). Both fail on master:With the fix:
npm test175 passing,npm run lintclean. A HISTORY.md entry is included.