Repository navigation
Conversation
… URL Previously, res.redirect(undefined) would silently send a malformed Location: undefined header while only printing a deprecation warning. Now it throws a TypeError for falsy URL values (undefined, null, '') and non-string URLs, preventing invalid HTTP responses. Fixes expressjs#6941
Contributor
|
Duplicate of #6404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6941
Previously,
res.redirect(undefined)would silently send a malformedLocation: undefinedheader while only printing a deprecation warning. The HTTP response would contain an invalid Location header that clients cannot properly follow.This change throws a
TypeErrorfor:undefined,null,'')This prevents invalid HTTP responses and surfaces bugs early during development instead of silently sending broken redirects.