Repository navigation
Share outbound destination handling - #2625
Conversation
dd5a78b to
544159a
Compare
544159a to
5cb89fc
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 101a56d423
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Blake Niemyjski <bniemyjski@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Review the latest head and its updated AGENTS.md guidance. The obsolete internal IsPublicAddress forwarding method is intentionally removed; do not request restoring a compatibility wrapper for this internal helper. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Public metadata and source-map downloads need to validate their actual destination and retain useful errors when connections fail. This centralizes public-address checks, disables cookies and proxies for these anonymous downloads, and preserves the original connection error if socket cleanup fails.
Validation: source review and
git diff --checkpassed. Exact-head build, focused tests and CI are pending.Removes the obsolete internal
IsPublicAddressforwarding method. AGENTS.md clarifies internal helper contracts and exception logging conventions. The documented cleanup helper uses: {Message}without trailing periods. Moq covers cleanup failure; registration tests cover all three HTTP clients. HTTP API and configuration contracts are unchanged.