Repository navigation
Reject a trailing newline in SlugField - #10075
Open
mohamed-alired wants to merge 1 commit into
Open
mohamed-alired wants to merge 1 commit into
mohamed-alired wants to merge 1 commit into
Conversation
The ASCII slug regex ended in `$`, which also matches just before a trailing newline, so with trim_whitespace=False 'slug\n' was accepted. Use `\Z`, as the allow_unicode branch and Django's validate_slug already do.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ASCII
SlugFieldregex ends in$, which in Python also matches just before a trailing newline, so withtrim_whitespace=Falsethe value'slug\n'is accepted:The
allow_unicode=Truebranch already uses\Z, as does Django'svalidate_slug. This change uses\Zfor the ASCII regex too. The OpenAPI generator already translates\Zto\zforpattern, so schemas stay valid.Tests:
test_trailing_newline_is_invalidcovers both branches. It fails onmainand passes with this change.