Repository navigation
SarAsio: don't crash the host on long endpoint names or bad channel counts - #152
Draft
eiz-claude wants to merge 2 commits into
Draft
eiz-claude wants to merge 2 commits into
eiz-claude wants to merge 2 commits into
Conversation
Adds a long-endpoint-name scenario to the issues group: a host whose endpoint names are 92 characters, past the driver's 63-character limit. Layouts take --id-prefix so the IDs can stay short. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SarClient copied endpoint names and IDs into the driver request with wcscpy_s, which aborts the process when the value doesn't fit the driver's 63 characters, and the endpoint dialog let names of any length through. A name of 64 characters or more killed the DAW on start. Names are now truncated (and the dialog limits them), and an over-long ID, which can only come from an edited configuration, fails the start with a log message instead. The dialog also parsed the channel count with std::stoi, which throws on an empty or non-numeric value. It now accepts 1 to 32 (the driver's limit; larger counts made endpoint creation fail) and otherwise says so and stays open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two ways the endpoint dialog's input crashed the host. No open issue clearly matches either; both turned up while triaging the issue list, next to the
strcpy_schannel-name crash fixed in #145.Long endpoint names.
SarClient::createEndpointscopied each endpoint's name and ID into the driver request withwcscpy_s. That aborts the process (fail-fast,0xC0000409) when the value doesn't fit the driver's 63 characters, and the dialog accepted names of any length. A name of 64 or more characters killed the DAW as soon as it started SAR.Channel count. The dialog parsed the channel count with
std::stoi, which throws on an empty or non-numeric value. It now accepts 1 to 32, the driver'sSAR_MAX_CHANNEL_COUNT; larger counts made endpoint creation fail later anyway. Otherwise it says so and keeps the dialog open.Test
New
long-endpoint-namescenario: a host whose endpoint names are 98 characters long, with short IDs (--id-prefix, new).0xC0000409at startThe dialog changes (name limit, channel count check) aren't driven by the harness.
🤖 Generated with Claude Code