Repository navigation
improve server configuration tests - #498
Draft
marcosbento wants to merge 14 commits into
Draft
marcosbento wants to merge 14 commits into
marcosbento wants to merge 14 commits into
Conversation
Clarify configuration precedence and file lookup before and after the change to ECF_HOME, including security-file naming and reload behaviour.
Require the shipped fixture to exist at its current path and verify non-default settings, preventing silent fallback to built-in defaults.
Resolve the home against the startup directory before constructing checkpoint paths or changing directory, preventing double resolution.
Report the configuration filename and original parser error before applying environment overrides or creating startup files. Keep missing and empty configuration files optional.
Report unsupported or explicitly empty ECF_CHECKMODE values with the allowed modes. Keep CHECK_ON_TIME as the default for an absent setting.
Validate the effective ECF_CHECKINTERVAL after environment overrides and report the invalid value and positive-integer requirement.
Clarify configuration loading before the change to ECF_HOME and distinguish startup-directory discovery from runtime file resolution.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #498 +/- ##
===========================================
+ Coverage 57.27% 57.77% +0.49%
===========================================
Files 1269 1273 +4
Lines 107158 108495 +1337
Branches 15481 15642 +161
===========================================
+ Hits 61376 62683 +1307
- Misses 45782 45812 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Verify startup-directory discovery before changing to ECF_HOME, including default settings and conflicting server-home configurations.
Verify config, environment and CLI precedence, including resolved paths and unsupported environment overrides. Ensure config parsing errors remain fatal despite valid higher-priority inputs.
Cover filename forms through config and environment inputs. Verify live-server file access, checkpoint destinations, security-file selection and exported definition paths.
Verify default and dot homes, clean rejection of unusable homes, and preservation of startup-side logs when runtime files use a separate home.
Reject unusable config files, empty required settings and non-positive effective profiling thresholds. Add parsing and boundary regressions while preserving supported environment overrides.
Let help and version bypass runtime settings while retaining CLI validation and override precedence. Reject parser errors cleanly and cover argument handling with executable regressions.
Reject non-regular security paths and report password host/port mismatches. Add executable regressions for file selection, missing and invalid files, access controls and failed-start cleanup.
marcosbento
force-pushed
the
task/test_server_configuration
branch
from
October 23, 2026 08:16
d30b1ae to
fa4f9e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per PR title - see individual commit messages for details.
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-498