Repository navigation
Conversation
Catch RejectedExecutionException around submission and run the same notification task synchronously. Add a regression test that verifies the persist listener is notified when submission is rejected. Fixes ebean-orm#2565
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Commits during shutdown can lose post-commit notifications and log a notification failure.
When the background executor rejects submission, the exception reaches the outer logging handler and the notification task never runs.
What this changes
Catch RejectedExecutionException around submission and run the same notification task synchronously. Add a regression test that verifies the persist listener is notified when submission is rejected.
How it was tested
Mvn -B -ntp -pl ebean-core -am test-compile completed successfully; it compiled test sources without running tests. The tests in
ebean-core/src/test/java/io/ebeaninternal/server/transaction/TransactionManagerNotifyOfCommitTest.javafail without the fix in the ebean TransactionManager change (checked by reverting the source changes).Fixes #2565