Failed to add task but still reported success #22

Activity

1. progers-de commented on Aug 5, 2024

   

   progers-de

   on Aug 5, 2024

   More actions

   Just hit this same problem this week
2. beauraines commented on Aug 9, 2024

   

   beauraines

   on Aug 9, 2024

   ContributorAuthor

   More actions

   I may have some time this weekend to troubleshoot this.

   👍React with 👍1Reacted by Peter Rogers
3. progers-de commented on Aug 9, 2024

   

   progers-de

   on Aug 9, 2024

   More actions

   FWIW, I've solved the underlying problem for myself by using the npm version instead of the .exe, but yeah, worth seeing why it says "Task(s) added" when no tasks were added
4. beauraines commented on Aug 18, 2024

   

   beauraines

   on Aug 18, 2024

   ContributorAuthor

   More actions

   This is where the problem is coming from

   https://github.com/beauraines/rtm-cli/blob/870a8a7408e25f71830e3eae123c7a00eaf84034/src/cmd/add.js#L42-L71

   /**
    * Process the request
    * @private
    */
   function _process(task, count=1, max=1) {
     log.spinner.start("Adding New Task(s)...");
     config.user(function(user) {
       task = _parseTask(task);
   
       // Add Task
       user.tasks.add(task, function(err) {
         if ( err ) {
           log.spinner.error("Could not add new Task #" + count + " (" + err.msg + ")");
         }
         _processFinished(count, max);
       });
     });
   }
   
   /**
    * Request Callback
    * @private
    */
   function _processFinished(count, max) {
     log.spinner.start("Adding Task [" + count + "/" + max + "]...");
     if ( count === max ) {
       log.spinner.success("Task(s) Added");
       return finish();
     }
   }

   If there is an error, it displays that there was an error, but once all the tasks have been processed, it still goes on to _processFinished It seems that _processFinished should take the err as an argument and then display log.spinner.error() with some error message.

   However, this pattern repeats itself through each of the commands...

   👍React with 👍1Reacted by Peter Rogers