Repository navigation
Use ArrayBuffer for read buffer management in HttpConnection - #79524
Merged
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #61223 This PR is a drop-in replacement of the original read buffer management. I haven't changed any of the functionality (pooling, zero-byte reads, etc.), but this change makes it easier for us to do so in the future (main reason why I'm doing this).
|
rzikm
approved these changes
Dec 12, 2022
rzikm
left a comment
Member
There was a problem hiding this comment.
Looks great!, one minor comment to address.
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oldzhu
pushed a commit
to oldzhu/runtime
that referenced
this pull request
Jan 1, 2023
…79524) * Use ArrayBuffer for read buffer management in HttpConnection * Update outdated comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #61223
This PR is a drop-in replacement of the original read buffer management.
IMO it makes the code more maintainable and easier to read.
I haven't changed any of the functionality (pooling, zero-byte reads, etc.), but this change makes it easier for us to do so in the future (main reason why I'm doing this).