镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

don't run the System.IO.FileSystem.DriveInfo tests in parallel #62134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 3 commits into from
Dec 1, 2021
Merged

don't run the System.IO.FileSystem.DriveInfo tests in parallel #62134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca9861a
don't run the System.IO.FileSystem.DriveInfo in parallel, fixes #62119
adamsitnik Nov 29, 2021
a566981
Merge remote-tracking branch 'upstream/main' into issue62119
adamsitnik Nov 30, 2021
92ec2b5
unify disabling test parallelization per assembly
adamsitnik Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ests/System/Xml/DisableParallelization.cs → ...stem/DisableParallelizationPerAssembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Tests are old and depend on the static state
[assembly: Xunit.CollectionBehavior(DisableTestParallelization = true)]
[assembly: Xunit.CollectionBehavior(DisableTestParallelization = true)]
1 change: 1 addition & 0 deletions ...ibraries/System.IO.FileSystem.DriveInfo/tests/System.IO.FileSystem.DriveInfo.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
<Compile Include="DriveInfo.Windows.Tests.cs" Condition="'$(TargetsWindows)' == 'true'" />
<Compile Include="VirtualDrives.Windows.Tests.cs" Condition="'$(TargetsWindows)' == 'true'" />
<Compile Include="$(CommonTestPath)System\IO\VirtualDriveHelper.Windows.cs" Link="Common\System\IO\VirtualDriveHelper.Windows.cs" Condition="'$(TargetsWindows)' == 'true'" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion ...rivate.Xml/tests/Readers/CharCheckingReader/System.Xml.RW.CharCheckingReader.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ItemGroup>
<Compile Include="CharReaderTests.cs" />
<Compile Include="InheritedCases.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\ModuleCore\ModuleCore.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...ies/System.Private.Xml/tests/Readers/CustomReader/System.Xml.RW.CustomReader.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ItemGroup>
<Compile Include="CReaderTestModule.cs" />
<Compile Include="InheritedCases.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\ModuleCore\ModuleCore.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...s/System.Private.Xml/tests/Readers/FactoryReader/System.Xml.RW.FactoryReader.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<Compile Include="InheritedCases.cs" />
<Compile Include="Normalization.cs" />
<Compile Include="TCNormalization.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\ModuleCore\ModuleCore.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...libraries/System.Private.Xml/tests/Readers/NameTable/System.Xml.RW.NameTable.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<Compile Include="TCUserNameTable.cs" />
<Compile Include="TestFiles.cs" />
<Compile Include="XmlNameTable.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\ModuleCore\ModuleCore.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...System.Private.Xml/tests/Readers/ReaderSettings/System.Xml.RW.ReaderSettings.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<Compile Include="TCOneByteStream.cs" />
<Compile Include="TCReaderSettings.cs" />
<Compile Include="TCRSGeneric.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\BaseLibManaged\BaseLibManaged.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...s/System.Private.Xml/tests/Readers/SubtreeReader/System.Xml.RW.SubtreeReader.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ItemGroup>
<Compile Include="InheritedCases.cs" />
<Compile Include="SubtreeReaderTests.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\ModuleCore\ModuleCore.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...s/System.Private.Xml/tests/Readers/WrappedReader/System.Xml.RW.WrappedReader.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ItemGroup>
<Compile Include="InheritedCases.cs" />
<Compile Include="WrappedReaderTests.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\ModuleCore\ModuleCore.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...libraries/System.Private.Xml/tests/Writers/RwFactory/System.Xml.RW.RwFactory.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<Compile Include="CXmlDriverVariation.cs" />
<Compile Include="ReaderFactory.cs" />
<Compile Include="WriterFactory.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\ModuleCore\ModuleCore.csproj" />
Expand Down
5 changes: 0 additions & 5 deletions src/libraries/System.Private.Xml/tests/Writers/XmlWriterApi/DisableParallelization.cs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...ies/System.Private.Xml/tests/Writers/XmlWriterApi/System.Xml.RW.XmlWriterApi.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<Compile Include="TCNewLineChars.cs" />
<Compile Include="TCNewLineHandling.cs" />
<Compile Include="TCNewLineOnAttributes.cs" />
<Compile Include="DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
<Compile Include="TCOmitXmlDecl.cs" />
<Compile Include="TCStandAlone.cs" />
<Compile Include="TCWriteAttributes.cs" />
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Private.Xml/tests/XmlConvert/System.Xml.RW.XmlConvert.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<Compile Include="XmlIdeographicCharConvertTests1.cs" />
<Compile Include="XmlIdeographicCharConvertTests2.cs" />
<Compile Include="XmlIdeographicCharConvertTests3.cs" />
<Compile Include="$(CommonTestPath)System\Xml\DisableParallelization.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)System\Xml\ModuleCore\ModuleCore.csproj" />
Expand Down