Repository navigation
Make GCMemoryInfoData blittable - #58738
Merged
Merged
Conversation
The runtime side makes assumptions about the layout of this class, but since the class is not blittable, the runtime is free to reorder the fields however it sees fit (`StructLayout(LayoutKind.Sequential)` only affects the *managed* layout of blittable classes - it's not documented to do anything to the managed layout of non-blittable classes). This prevents improvements to managed layout such as dotnet#51416.
Member
Author
Sigh. If I'm reading the tea leaves right, his is failing on 32bit platforms because the native side will try to align the beginning of I wonder if the best course of action would be to just rewrite the FCall to take a reference to the first field of |
Member
|
@MichalStrehovsky PTLA at my suggested fix. |
Member
Author
Clever! Thank you! I've re-kicked the failing CI leg because it looks like the known infra issue (collection was modified). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime side makes assumptions about the layout of this class, but since the class is not blittable, the runtime is free to reorder the fields however it sees fit (
StructLayout(LayoutKind.Sequential)only affects the managed layout of blittable classes - it's not documented to do anything to the managed layout of non-blittable classes).This prevents improvements to managed layout such as #51416.