Repository navigation
Fix handling of not found exported types - #50845
Merged
Merged
Conversation
This was missed in #50437. Wonder if we should have just introduced a new overload of GetType that returns `object`. This "return resolution failure that we then need to not forget to check" looks like a potential bug farm. ```csharp public MetadataType GetType(string nameSpace, string name, bool throwIfNotFound = true) { /* the obvious implementation that calls the virtual method */ } public abstract object GetType(string nameSpace, string name, NotFoundBehavior notFoundBehavior) ```
Member
Author
|
Looks like David is out - @dotnet/crossgen-contrib could someone have a look? |
trylek
approved these changes
Apr 7, 2021
trylek
left a comment
Member
There was a problem hiding this comment.
The proximate fix looks good to me. I defer to David to comment on the broader design considerations you posited.
Member
Author
I'll make sure to ask that question again when this landmine explodes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in #50437.
Wonder if we should have just introduced a new overload of GetType that returns
object. This "return resolution failure that we then need to not forget to check" looks like a potential bug farm.