Use OutputRid for host packs by am11 · Pull Request #45041 · dotnet/runtime

am11 · 2020-11-21T00:08:07Z

cc @safern, we get the following output in linux-musl-arm64 container:

expand

  [ 98%] Building CXX object cli/apphost/static/CMakeFiles/singlefilehost.dir/__/__/__/corehost.cpp.o
  [ 99%] Linking CXX shared library libhostpolicy.so
  Stripping symbols from $<TARGET_FILE:hostpolicy> into file $<TARGET_FILE:hostpolicy>.dbg
  [ 99%] Linking CXX shared library libhostfxr.so
  [ 99%] Built target hostpolicy
  Stripping symbols from $<TARGET_FILE:hostfxr> into file $<TARGET_FILE:hostfxr>.dbg
  [ 99%] Built target hostfxr
  [100%] Linking CXX executable singlefilehost
  Stripping symbols from $<TARGET_FILE:singlefilehost> into file $<TARGET_FILE:singlefilehost>.dbg
  [100%] Built target singlefilehost
  Install the project...
  -- Install configuration: "RELEASE"
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/singlefilehost.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/singlefilehost
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/apphost.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/apphost
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/dotnet.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/dotnet
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/coreclr_delegates.h
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/hostfxr.h
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/nethost.h
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libnethost.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libnethost.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libnethost.a
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/test_fx_ver
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libhostfxr.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libhostfxr.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libhostpolicy.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libhostpolicy.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockcoreclr.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockcoreclr.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockhostfxr_2_2.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockhostfxr_2_2.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockhostpolicy.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockhostpolicy.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/nativehost.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/nativehost
  Microsoft.NETCore.DotNetHost -> /runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHost.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHostPolicy -> /runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHostResolver -> /runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostResolver.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHost -> /runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHost.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHostPolicy -> /runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHostPolicy.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHostResolver -> /runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHostResolver.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetAppHost -> /runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetAppHost.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetAppHost -> /runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetAppHost.6.0.0-dev.nupkg
  Microsoft.NETCore.App.Ref -> 
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Ref.6.0.0-dev.nupkg'.
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Ref.6.0.0-dev.symbols.nupkg'.
  Microsoft.NETCore.App.Runtime -> 
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.linux-musl-arm64.6.0.0-dev.nupkg'.
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.linux-musl-arm64.6.0.0-dev.symbols.nupkg'.
  Microsoft.NETCore.App.Host -> 
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Host.linux-musl-arm64.6.0.0-dev.nupkg'.
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Host.linux-musl-arm64.6.0.0-dev.symbols.nupkg'.
  Microsoft.NETCore.App.Crossgen2 -> 
  dotnet-host -> 
  dotnet-hostfxr -> 
  dotnet-runtime-deps-centos.7 -> 
  dotnet-runtime-deps-debian -> 
  dotnet-runtime-deps-fedora.27 -> 
  dotnet-runtime-deps-opensuse.42 -> 
  dotnet-runtime-deps-oraclelinux.7 -> 
  dotnet-runtime-deps-rhel.7 -> 
  dotnet-runtime-deps-sles.12 -> 
  Microsoft.NETCore.App.Bundle -> 
  Microsoft.NET.HostModel -> /runtime/artifacts/bin/Microsoft.NET.HostModel/Release/netstandard2.0/Microsoft.NET.HostModel.dll
  Successfully created package '/runtime/artifacts/packages/Release/NonShipping/Microsoft.NET.HostModel.6.0.0-dev.nupkg'.
  Successfully created package '/runtime/artifacts/packages/Release/NonShipping/Microsoft.NET.HostModel.6.0.0-dev.symbols.nupkg'.
  TestUtils -> /runtime/artifacts/bin/TestUtils/Release/net6.0/TestUtils.dll
  Microsoft.NET.HostModel.ComHost.Tests -> /runtime/artifacts/bin/Microsoft.NET.HostModel.ComHost.Tests/Release/net6.0/Microsoft.NET.HostModel.ComHost.Tests.dll
  Microsoft.DotNet.CoreSetup.Packaging.Tests -> /runtime/artifacts/bin/Microsoft.DotNet.CoreSetup.Packaging.Tests/Release/net6.0/Microsoft.DotNet.CoreSetup.Packaging.Tests.dll
  BundleHelper -> /runtime/artifacts/bin/BundleHelper/Release/net6.0/BundleHelper.dll
  Microsoft.NET.HostModel.AppHost.Tests -> /runtime/artifacts/bin/Microsoft.NET.HostModel.AppHost.Tests/Release/net6.0/Microsoft.NET.HostModel.AppHost.Tests.dll
  HostActivation.Tests -> /runtime/artifacts/bin/HostActivation.Tests/Release/net6.0/HostActivation.Tests.dll
  AppHost.Bundle.Tests -> /runtime/artifacts/bin/AppHost.Bundle.Tests/Release/net6.0/AppHost.Bundle.Tests.dll
  Microsoft.NET.HostModel.Bundle.Tests -> /runtime/artifacts/bin/Microsoft.NET.HostModel.Bundle.Tests/Release/net6.0/Microsoft.NET.HostModel.Bundle.Tests.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:01:15.85

safern

Other than a question, LGTM

safern · 2020-11-21T00:33:17Z

Thanks for fixing this. I'll look at the result on those builds on CI and merge if everything makes sense.

am11 · 2020-11-21T00:36:12Z

Is it possible to trigger the official build pipeline (or something close), while PR is still opened? If so, please trigger them too. :)

safern · 2020-11-21T00:43:49Z

Is it possible to trigger the official build pipeline (or something close), while PR is still opened? If so, please trigger them too. :)

Yeah, doing that. I need to mirror your branch 😄

safern · 2020-11-21T01:11:44Z

I've queued the official build, will let you know the results.

safern · 2020-11-21T01:58:52Z

It seems like the official build will be green:

 Microsoft.NETCore.DotNetHostPolicy -> /root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHostPolicy.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHostResolver -> /root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHostResolver.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHost -> /root/runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHost.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHost -> /root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHost.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHostResolver -> /root/runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostResolver.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHostPolicy -> /root/runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetAppHost -> /root/runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetAppHost.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetAppHost -> /root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetAppHost.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.App.Ref -> 
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Ref.6.0.0-alpha.1.20570.13.nupkg'.
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Ref.6.0.0-alpha.1.20570.13.symbols.nupkg'.
  Microsoft.NETCore.App.Runtime -> 
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.linux-musl-arm64.6.0.0-alpha.1.20570.13.nupkg'.
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.linux-musl-arm64.6.0.0-alpha.1.20570.13.symbols.nupkg'.
  Microsoft.NETCore.App.Host -> 
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Host.linux-musl-arm64.6.0.0-alpha.1.20570.13.nupkg'.
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Host.linux-musl-arm64.6.0.0-alpha.1.20570.13.symbols.nupkg'.

FYI for whoever didn't see the issue, discussion on the fix is here: #45027 (comment)

safern · 2020-11-21T03:12:18Z

Official build is green and with expected outputs. Merging

Dotnet-GitSync-Bot added the area-Setup label Nov 21, 2020

safern requested review from jkoritzinsky and safern November 21, 2020 00:13

safern reviewed Nov 21, 2020

View reviewed changes

Comment thread src/installer/pkg/projects/Directory.Build.props Resolved

safern requested a review from dagood November 21, 2020 00:15

safern approved these changes Nov 21, 2020

View reviewed changes

Use OutputRid for host packs

4da81e8

dagood requested review from NikolaMilosavljevic and removed request for dagood November 21, 2020 00:44

safern merged commit 6c80a3d into dotnet:master Nov 21, 2020

safern mentioned this pull request Nov 21, 2020

Linux and Linux-MUSL Package artifacts getting produced with duplicate RIDs #45027

Closed

am11 deleted the feature/consolidation/msbuild-properties branch November 25, 2020 02:53

ghost locked as resolved and limited conversation to collaborators Dec 25, 2020

Navigation Menu

Repository navigation

Use OutputRid for host packs - #45041

Use OutputRid for host packs#45041
safern merged 1 commit into
dotnet:masterfrom
am11:feature/consolidation/msbuild-properties

am11 commented Nov 21, 2020

Uh oh!

Uh oh!

safern left a comment

Uh oh!

safern commented Nov 21, 2020

Uh oh!

am11 commented Nov 21, 2020

Uh oh!

safern commented Nov 21, 2020

Uh oh!

safern commented Nov 21, 2020

Uh oh!

safern commented Nov 21, 2020

Uh oh!

safern commented Nov 21, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

am11 commented Nov 21, 2020

Uh oh!

Uh oh!

safern left a comment

Choose a reason for hiding this comment

Uh oh!

safern commented Nov 21, 2020

Uh oh!

am11 commented Nov 21, 2020

Uh oh!

safern commented Nov 21, 2020

Uh oh!

safern commented Nov 21, 2020

Uh oh!

safern commented Nov 21, 2020

Uh oh!

safern commented Nov 21, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants