Repository navigation
Conversation
Manually backport dotnet#136959 to release/9.0-staging. Keep the Unicode 15 attribution and this branch's pinned ICU source, and omit Intel decimal math because that implementation is not compiled on .NET 9. Preserve existing license terms and unrelated notice text. Attribute embedded TZif data separately from ICU's filtered timezone data. (cherry picked from commit ed70a9a) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
AFAIK we already closed branch for the last 9.0 release therefore closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This pull request was generated with AI assistance. Please review before merging.
Backport of #136959 to release/9.0-staging
/cc @krwq
Corrects third-party attributions identified during a license review in the package and installed-product notice inputs. This manual backport includes only notices applicable to .NET 9 and preserves the branch's existing legal terms.
Customer Impact
Third-party notices should cover the code and dependencies included in runtime distributions. The installed-product notice currently omits several Libraries attributions, and both notice inputs omit applicable ICU attributions. This PR corrects those omissions and source-backed copyright spans; it does not change runtime behavior.
Regression
Corrects pre-existing notice omissions and stale attribution dates, not a runtime behavior regression.
Testing
Checked both notice inputs against the .NET 9 compile list, generated Unicode data, and pinned ICU sources, build filters, and actual prebuilt data resource tables. Verified applicable attributions, preservation of unrelated text and existing legal terms, duplicate grants and bodies, and the existing NuGet and installer delivery paths.
Commands run from the repository root (
NOTICE_VALIDATION_DIRpoints to the session-local verification files):Results: the verifier passed all 243 checks; the diff check passed.
No runtime build was run or runtime tests added because only the two notice files change.
Risk
Low. Text-only corrections in existing notice inputs; no runtime code, APIs, dependencies, package authoring, or delivery wiring changes. The backport retains the Unicode 15 attribution and the actual .NET 9 ICU pin, and excludes Intel decimal math because that source is not compiled on this branch.
The Time Zone Database notice covers the embedded TZif data used by System.Native on browser and WASI, separately from ICU's excluded timezone data.
The target is
release/9.0-staging, as required for .NET 9 servicing. No NuGet project packability or version changes are included.