Repository navigation
[wasm] Assert Regex is absent before new-assembly rebuild - #137035
Merged
akoeplinger merged 1 commit intoNov 6, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
lewing
approved these changes
Nov 5, 2026
maraf
reviewed
Nov 6, 2026
| ProjectInfo info = CopyTestAsset(config, aot, TestAsset.WasmBasicTestApp, "rebuild_tasks"); | ||
| BuildPaths paths = await FirstNativeBuildAndRun(info, config, aot, nativeRelink, invariant); | ||
|
|
||
| WasmSdkBasedProjectProvider provider = GetProvider<WasmSdkBasedProjectProvider>(); |
Member
There was a problem hiding this comment.
I checked this test's Helix testResults.xml artifacts from build 1666420: both Linux Mono lanes run with fingerprinting, producing names such as System.Text.RegularExpressions.n0pescj9i3.wasm and System.Text.RegularExpressions.5hiaytntjz.dll. All three Release cases pass in each lane; NoWebcil disables WebCIL, not fingerprinting, so these runs do not establish coverage with fingerprinting disabled.
Note
This comment was generated with the assistance of GitHub Copilot.
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReferenceNewAssemblyrelies on the replacement entry point introducingSystem.Text.RegularExpressionsso that the AOT module table changes. Assert that the first publish does not already contain that assembly, making a future shared-fixture dependency change fail at the violated precondition rather than at the laterdriver-gen.ctimestamp comparison.The assertion checks both
coreAssemblyandassemblyin the boot manifest, using logical paths to support fingerprinted files and both DLL and WebCIL output.Related to #130616. The same test assumption was invalidated on release/10.0 when #131361 added crypto usage to the shared memory-test fixture.
Note
This change and description were created with GitHub Copilot.