Repository navigation
JIT: Always clear references in async return values - #136830
Merged
jakobbotsch merged 1 commit intoNov 4, 2026
Merged
Conversation
We clear references after copying it to the user to avoid retaining objects in the return value. However, this code only ran when there was a user. Change the logic to always clear object references, regardless of whether there is a user. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2846cf7e-ff37-489b-a02c-246210e7fece
|
Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
marked this pull request as ready for review
November 3, 2026 07:28
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS Diffs. Size regressions which are expected. |
AndyAyersMS
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We clear references after copying it to the user to avoid retaining objects in the return value. However, this code only ran when there was a user. Change the logic to always clear object references, regardless of whether there is a user.
Fixes #115686 (comment)