镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Remove unused CoreLib binder registrations and dead dispatch helpers - #136536

Merged
jkoritzinsky merged 4 commits into
dotnet:mainfrom
jkoritzinsky:dev/jkoritzinsky/corelib-binder-audit
Oct 28, 2026
Merged

jkoritzinsky merged 4 commits into
dotnet:mainfrom
jkoritzinsky:dev/jkoritzinsky/corelib-binder-audit

Conversation

@jkoritzinsky

@jkoritzinsky jkoritzinsky commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Remove unused CoreLib binder entries as this roots managed code unnecessarily.

Note

This pull request was generated with GitHub Copilot.

Remove unreachable binder consumers and recursively prune orphaned signatures and class registrations while preserving ILLink entries and indexed array helpers.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Comment thread src/coreclr/vm/metasig.h Resolved
Comment thread src/coreclr/vm/metasig.h Resolved
Comment thread src/coreclr/vm/corelib.h Resolved
Comment thread src/coreclr/vm/corelib.h Resolved
jkoritzinsky and others added 2 commits October 27, 2026 15:20
Keep the 64-bit padding field rooted for ILLink so unsafe array accesses retain the required data offset, without adding unused native binder entries.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment thread src/coreclr/vm/corelib.h Resolved
@jkoritzinsky

Copy link
Copy Markdown
Member Author

/ba-g Helix auth failures.

@jkoritzinsky
jkoritzinsky merged commit 383c1e1 into dotnet:main Oct 28, 2026
92 of 103 checks passed
@github-project-automation github-project-automation Bot moved this to Done in AppModel Oct 28, 2026
@jkoritzinsky
jkoritzinsky deleted the dev/jkoritzinsky/corelib-binder-audit branch October 28, 2026 17:30
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants