Repository navigation
Guard EncryptedXml_DecryptDocument_MaxCount_Default with RemoteExecutor.IsSupported - #136119
Merged
Merged
Conversation
…or.IsSupported The test calls RemoteExecutor.Invoke but was a plain [Fact], so it throws PlatformNotSupportedException where RemoteExecutor isn't supported (e.g. crossgen2 outerloop R2R library runs). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
lewing
enabled auto-merge (squash)
October 20, 2026 01:18
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
jkotas
approved these changes
Oct 20, 2026
lewing
added a commit
that referenced
this pull request
Nov 11, 2026
…yptedXml tests (#137306) Fixes Issue N/A (CI test failures on release/11.0, see Description) main PR #135273, #135618, #135975, #136119 # Description Backports four test-only fixes from main. They are cherry-picked with `-x` in this order and all applied cleanly: 1. #135273 (a4802e5): Isolate HttpClient certificate validation tests from TLS resumption 2. #135618 (f521600): Replace badssl HTTP certificate tests with loopback servers 3. #135975 (39ab468): Fix Android HTTP certificate validation tests 4. #136119 (677ab53): Guard `EncryptedXml_DecryptDocument_MaxCount_Default` with `RemoteExecutor.IsSupported` These tests fail in rolling (non-PR) CI on release/11.0 but don't fail on main. The failures come from Kusto `engsrvprod/engineeringdata` `AzureDevOpsTests`, non-PR CI over the last 21 days: - **HTTP certificate tests**: `SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.UseCallback_BadCertificate_ExpectedPolicyErrors`, `...NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds` and the `...DangerousAcceptAllCertificatesValidator...` tests. - They fail with `Connection reset by peer` against external `*.badssl.com` hosts. release/11.0 `Configuration.Http.cs` still points at badssl.com. - Up to 49 builds were affected. - #135618 and #135975 replace these external endpoints with loopback servers that use generated expired, wrong-host and self-signed certificates. - #135273 disables TLS resumption so certificate validation callbacks run on every connection. #135618 depends on it. - **`EncryptedXml_DecryptDocument_MaxCount_Default`**: fails on Android with `PlatformNotSupportedException: RemoteExecutor is not supported` (24 builds). #136119 makes the test conditional on `RemoteExecutor.IsSupported`. All 12 changed files are under `Common/tests` or `*/tests`. Product code is unchanged. # Customer Impact None. Only tests change. Taking this removes recurring false failures from release/11.0 CI. # Regression No. The failures are caused by external endpoints and platform test-infra limits, not product regressions. # Testing - The cherry-picks applied with no conflicts. The resulting tree matches a sequential `git merge-tree` simulation onto `origin/release/11.0`. - I checked that `git diff --name-only origin/release/11.0` contains only test files. - **I didn't build or run anything locally** (local disk space is limited). CI on this PR is the validation. # Risk Very low. Only test code changes, and it already ships on main. # Package authoring no longer needed in .NET 9 IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. > [!NOTE] > This PR description was generated with GitHub Copilot. --------- Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> Copilot-Session: 63463cf1-4bfe-42e3-ad96-49f35e245dd1
lewing
added a commit
that referenced
this pull request
Nov 11, 2026
…or.IsSupported (#136119) `EncryptedXml_DecryptDocument_MaxCount_Default` (added in #135741) calls `RemoteExecutor.Invoke` from a plain `[Fact]`, so it throws `PlatformNotSupportedException` where RemoteExecutor isn't supported, e.g. the `runtime-coreclr crossgen2` outerloop R2R library runs ([build 1639697](https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1639697)). This changes it to `[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]`, matching its sibling `_AppContext` tests. > [!NOTE] > This PR was generated with the assistance of GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 677ab53)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncryptedXml_DecryptDocument_MaxCount_Default(added in #135741) callsRemoteExecutor.Invokefrom a plain[Fact], so it throwsPlatformNotSupportedExceptionwhere RemoteExecutor isn't supported, e.g. theruntime-coreclr crossgen2outerloop R2R library runs (build 1639697). This changes it to[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))], matching its sibling_AppContexttests.Note
This PR was generated with the assistance of GitHub Copilot.