镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Add Utf8JsonReader.AllowMultipleValues and related APIs. - #104328

Merged
eiriktsarpalis merged 8 commits into
dotnet:mainfrom
eiriktsarpalis:utf8jsonreader-multipleitems
Jul 4, 2024
Merged

Add Utf8JsonReader.AllowMultipleValues and related APIs.#104328
eiriktsarpalis merged 8 commits into
dotnet:mainfrom
eiriktsarpalis:utf8jsonreader-multipleitems

Conversation

@eiriktsarpalis

@eiriktsarpalis eiriktsarpalis commented Jul 2, 2024

Copy link
Copy Markdown
Member

Fix #33030.

@ghost

ghost commented Jul 2, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost

ghost commented Jul 2, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service

dotnet-policy-service Bot commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@eiriktsarpalis
eiriktsarpalis requested a review from jozkee July 2, 2024 20:30
@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Jul 2, 2024
This was referenced Jul 3, 2024
Closed
Closed
Closed
stephentoub
stephentoub approved these changes Jul 3, 2024
View reviewed changes
Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Reader/JsonReaderOptions.cs Resolved
Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Stream.cs Resolved
Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Stream.cs Resolved
Comment thread ...s/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoOfT.ReadHelper.cs Resolved
Comment thread ...s/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoOfT.ReadHelper.cs Resolved
eiriktsarpalis and others added 3 commits July 3, 2024 23:31
@eiriktsarpalis @stephentoub
Update src/libraries/System.Text.Json/src/System/Text/Json/Reader/Jso…
903a919 
…nReaderOptions.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis @stephentoub
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
1f19017 
…ion/JsonSerializer.Read.Stream.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis
Address feedback
917597a
This was referenced Jul 4, 2024
Closed
Closed
@build-analysis build-analysis Bot mentioned this pull request Jul 4, 2024
Open
3 tasks
@build-analysis build-analysis Bot mentioned this pull request Jul 4, 2024
Closed
@eiriktsarpalis
eiriktsarpalis merged commit 3bad19f into dotnet:main Jul 4, 2024
@eiriktsarpalis
eiriktsarpalis deleted the utf8jsonreader-multipleitems branch July 4, 2024 16:12
@LoopedBard3

LoopedBard3 commented Jul 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Potential regressions:
Linux x64: dotnet/perf-autofiling-issues#37867, dotnet/perf-autofiling-issues#37804
Windows x64: dotnet/perf-autofiling-issues#37854, dotnet/perf-autofiling-issues#37816

@lewing lewing mentioned this pull request Jul 9, 2024
Open
This was referenced Jul 10, 2024
Closed
Closed
This was referenced Jul 12, 2024
Open
Open
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS left review comments
@stephentoub stephentoub stephentoub approved these changes
@jozkee jozkee Awaiting requested review from jozkee

Assignees

@eiriktsarpalis eiriktsarpalis

Labels

area-System.Text.Json new-api-needs-documentation

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Let Utf8JsonReader process input with one complete JSON document per line

4 participants

@eiriktsarpalis @LoopedBard3 @SteveSandersonMS @stephentoub