镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Assertion failed '!op1->isUsedFromMemory()' #76511

New issue
New issue
Closed
#76517
Closed
Assertion failed '!op1->isUsedFromMemory()'#76511
#76517
Assignees
tannergooding
Labels
arch-arm64area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIblocking-outerloopBlocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
Milestone
8.0.0

Description

@BruceForstall
BruceForstall
opened on Oct 2, 2022

"runtime-coreclr outerloop" R2R-CG2 test failures on arm64 in JIT\Regression\JitBlue\Runtime_76273\Runtime_76273\Runtime_76273.cmd:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=37881&view=ms.vss-test-web.build-test-results-tab&runId=755738&resultId=108102&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

    JIT\Regression\JitBlue\Runtime_76273\Runtime_76273\Runtime_76273.cmd [FAIL]
      
      Return code:      1
      Raw output file:      D:\h\w\B49209AE\w\A7DB0945\uploads\Reports\JIT.Regression\JitBlue\Runtime_76273\Runtime_76273\Runtime_76273.output.txt
      Raw output:
      BEGIN EXECUTION
      Runtime_76273.dll
              1 file(s) copied.
       7:07:25.95
      Response file: D:\h\w\B49209AE\w\A7DB0945\e\JIT\Regression\JitBlue\Runtime_76273\Runtime_76273\Runtime_76273.dll.rsp
      D:\h\w\B49209AE\w\A7DB0945\e\JIT\Regression\JitBlue\Runtime_76273\Runtime_76273\IL-CG2\Runtime_76273.dll
      -o:D:\h\w\B49209AE\w\A7DB0945\e\JIT\Regression\JitBlue\Runtime_76273\Runtime_76273\Runtime_76273.dll
      --targetarch:arm64
      --verify-type-and-field-layout
      --method-layout:random
      -r:D:\h\w\B49209AE\p\System.*.dll
      -r:D:\h\w\B49209AE\p\Microsoft.*.dll
      -r:D:\h\w\B49209AE\p\mscorlib.dll
      -r:D:\h\w\B49209AE\p\netstandard.dll
      -O
      " "dotnet" "D:\h\w\B49209AE\p\crossgen2\crossgen2.dll" @"D:\h\w\B49209AE\w\A7DB0945\e\JIT\Regression\JitBlue\Runtime_76273\Runtime_76273\Runtime_76273.dll.rsp"   -r:D:\h\w\B49209AE\w\A7DB0945\e\JIT\Regression\JitBlue\Runtime_76273\Runtime_76273\IL-CG2\*.dll"
      D:\a\_work\1\s\src\coreclr\jit\codegenarm64.cpp:4543
      Assertion failed '!op1->isUsedFromMemory()' in 'Program:M11(C0,short)' during 'Generate code' (IL size 87; hash 0xb0dcda0a; FullOpts)
      
       7:07:33.84
      Crossgen2 failed with exitcode - -2147483645
      Test Harness Exitcode is : 1

@dotnet/jit-contrib

Activity

  1. BruceForstall
    added
    arch-arm64
    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
    blocking-outerloopBlocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
    on Oct 2, 2022
  2. BruceForstall
    added this to the 8.0.0 milestone on Oct 2, 2022

  4. EgorBo commented on Oct 2, 2022

    @EgorBo
    EgorBo
    on Oct 2, 2022
    Member

    cc @tannergooding who added this test recently in #76273

  5. SingleAccretion commented on Oct 2, 2022

    @SingleAccretion
    SingleAccretion
    on Oct 2, 2022
    Contributor

    The fix:

    diff --git a/src/coreclr/jit/lower.cpp b/src/coreclr/jit/lower.cpp
index 176828d17ed..3fb6ed57317 100644
--- a/src/coreclr/jit/lower.cpp
+++ b/src/coreclr/jit/lower.cpp
@@ -2816,6 +2816,8 @@ GenTree* Lowering::OptimizeConstCompare(GenTree* cmp)
                 op2->gtType    = castToType;
 #endif
                 // If we have any contained memory ops on castOp, they must now not be contained.
+                castOp->ClearContained();
+
                 if (castOp->OperIs(GT_OR, GT_XOR, GT_AND))
                 {
                     GenTree* op1 = castOp->gtGetOp1();
@@ -2829,10 +2831,6 @@ GenTree* Lowering::OptimizeConstCompare(GenTree* cmp)
                         op2->ClearContained();
                     }
                 }
-                else
-                {
-                    castOp->ClearContained();
-                }

                 cmp->AsOp()->gtOp1 = castOp;

  6. tannergooding commented on Oct 2, 2022

    @tannergooding
    tannergooding
    on Oct 2, 2022
    Member

    Was getting more details on discord, this bug is really "unrelated" to the ADDEX change and is likely just exposed by it due to the other transforms happening.

    That being said, we are doing castOp->ClearContained() in IsContainableBinaryOp "too early" and we could probably do with fixing that as well.

  7. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Oct 2, 2022
  8. JulieLeeMSFT
    assigned
    tannergooding
    on Oct 3, 2022
  9. tannergooding
    closed this as completedin #76517on Oct 4, 2022
  10. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Oct 4, 2022
  11. ghost locked as resolved and limited conversation to collaborators on Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

arch-arm64area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIblocking-outerloopBlocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions