镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Improve test coverage for TLS resume #75545

Closed

Description

@wfurt

fix for #75079 did not have test as I was unable to construct one.
But in general, most tests do verify given behavior once but that may not be sufficient.
The behavior may change because of

  • session cache (primarily windows)
  • TLS resume (primarily Linux)

we should add test for #75079 as well as improve test coverage in general.

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Sep 13, 2022
  2. added this to the 8.0.0 milestone on Sep 13, 2022
  3. ghost removed
    untriagedNew issue has not been triaged by the area owner
    on Sep 13, 2022
  4. self-assigned this
    on Oct 18, 2022
  5. removed their assignment
    on Dec 2, 2022
  6. self-assigned this
    on Dec 29, 2022
  7. modified the milestones: 8.0.0, Future on Jun 9, 2023
  8. modified the milestones: Future, 9.0.0 on Jul 18, 2023
  9. rzikm commented on Oct 24, 2023

    @rzikm
    Member

    Triage:

    • Look at the coverage we already have and see if something is missing
    • consider adding tests that check if a session was actually resumed, there is a Debug-only property which we can check via Reflection.
  10. self-assigned this
    on Nov 16, 2023
  11. rzikm commented on Nov 27, 2023

    @rzikm
    Member

    Test covering #75079 was added as part of #79898, since then, multiple other changes have explicitly added checks with TLS resume as well, e.g. #86047. I don't think there are any missing tests at this point.

  12. removed their assignment
    on Nov 27, 2023
  13. locked and limited conversation to collaborators on Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions