镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Review .NET 5 usages #69028

New issue
New issue
Closed
#69911
Closed
Review .NET 5 usages#69028
#69911
Assignees
ArminShoeibi
Labels
area-Infrastructure
Milestone
8.0.0

Description

@am11
am11
opened on May 8, 2022

.NET 5 has reached its end of life today. We should review its remaining usages in the runtime repo and rev them to .NET 6 or 7 (preferably using variable like $(NetCoreAppCurrent) where possible).

# net 5 in file contents
% git grep -Eli 'net(coreapp)?5'

docs/design/coreclr/jit/viewing-jit-dumps.md
docs/workflow/building/libraries/cross-building.md
docs/workflow/debugging/coreclr/debugging.md
docs/workflow/testing/coreclr/running-aspnet-benchmarks-with-crossgen2.md
docs/workflow/testing/host/testing.md
eng/Signing.props
eng/common/SetupNugetSources.ps1
eng/common/SetupNugetSources.sh
eng/testing/performance/performance-setup.ps1
eng/testing/performance/performance-setup.sh
src/coreclr/tools/r2rtest/Commands/CompileNugetCommand.cs
src/installer/managed/Microsoft.NET.HostModel/Bundle/Manifest.cs
src/installer/managed/Microsoft.NET.HostModel/Bundle/TargetInfo.cs
src/installer/tests/Assets/TestProjects/PortableTestApp/PortableTestApp.csproj
src/installer/tests/Assets/TestProjects/StandaloneTestApp/StandaloneTestApp.csproj
src/installer/tests/HostActivation.Tests/FrameworkResolution/MultipleHives.cs
src/installer/tests/TestUtils/Constants.cs
src/libraries/Common/tests/StaticTestGenerator/Program.cs
src/libraries/Common/tests/StaticTestGenerator/README.md
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/AsyncServiceScope.cs
src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonReaderTest.cs
src/libraries/Microsoft.Extensions.FileProviders.Composite/tests/MockFileProvider.cs
src/libraries/Microsoft.Extensions.Hosting/tests/FunctionalTests/IntegrationTesting/src/Common/Tfm.cs
src/libraries/Microsoft.Extensions.Hosting/tests/FunctionalTests/ShutdownTests.cs
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs
src/libraries/System.Formats.Cbor/src/CompatibilitySuppressions.xml
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
src/libraries/System.Private.CoreLib/src/System/Random.Net5CompatImpl.cs
src/libraries/System.Private.CoreLib/src/System/Random.cs
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/AdditionalAttributesOnStub.cs
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/Compiles.cs
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/TestUtils.cs
src/libraries/System.Security.Permissions/src/CompatibilitySuppressions.xml
src/libraries/System.Text.Encoding.CodePages/src/Data/Tools/EncodingDataGenerator.csproj
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.WriteCore.cs
src/libraries/testPackages/testPackages.proj
src/native/corehost/bundle/header.h
src/tests/BuildWasmApps/Wasm.Build.Tests/BlazorWasmTests.cs
src/tests/BuildWasmApps/testassets/Blazor_net50/Blazor_net50.csproj
src/tests/BuildWasmApps/testassets/Blazor_net50/Program.cs
src/tests/BuildWasmApps/testassets/Blazor_net50/Shared/NavMenu.razor
src/tests/BuildWasmApps/testassets/Blazor_net50/_Imports.razor
src/workloads/workloads.csproj

# net 5 in file names
$ git ls-files | grep -Ei 'net(coreapp)?5'

src/libraries/System.Private.CoreLib/src/System/Random.Net5CompatImpl.cs
src/tests/BuildWasmApps/testassets/Blazor_net50/App.razor
src/tests/BuildWasmApps/testassets/Blazor_net50/Blazor_net50.csproj
src/tests/BuildWasmApps/testassets/Blazor_net50/Pages/Counter.razor
src/tests/BuildWasmApps/testassets/Blazor_net50/Pages/FetchData.razor
src/tests/BuildWasmApps/testassets/Blazor_net50/Pages/Index.razor
src/tests/BuildWasmApps/testassets/Blazor_net50/Program.cs
src/tests/BuildWasmApps/testassets/Blazor_net50/Shared/MainLayout.razor
src/tests/BuildWasmApps/testassets/Blazor_net50/Shared/MainLayout.razor.css
src/tests/BuildWasmApps/testassets/Blazor_net50/Shared/NavMenu.razor
src/tests/BuildWasmApps/testassets/Blazor_net50/Shared/NavMenu.razor.css
src/tests/BuildWasmApps/testassets/Blazor_net50/Shared/SurveyPrompt.razor
src/tests/BuildWasmApps/testassets/Blazor_net50/_Imports.razor

Activity

  1. am11
    added
    area-Infrastructure
    on May 8, 2022
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on May 8, 2022

  4. ViktorHofer commented on May 11, 2022

    @ViktorHofer
    ViktorHofer
    on May 11, 2022
    Member

    @am11 some of these are false positives but some can be updated to ie NetCoreAppToolCurrent or NetCoreAppCurrent. Would you like to send a PR? :)

  5. ArminShoeibi commented on May 25, 2022

    @ArminShoeibi
    ArminShoeibi
    on May 25, 2022
    Contributor

    @am11 some of these are false positives but some can be updated to ie NetCoreAppToolCurrent or NetCoreAppCurrent. Would you like to send a PR? :)

    Hello there Viktor, I can work on it.

  6. am11 commented on May 26, 2022

    @am11
    am11
    on May 26, 2022
    MemberAuthor

    @ArminShoeibi, feel free to take it. I am not actively working on it. There are also file names falling into that pattern, see the updated top post.

  7. ArminShoeibi commented on May 26, 2022

    @ArminShoeibi
    ArminShoeibi
    on May 26, 2022
    Contributor

    @ArminShoeibi, feel free to take it. I am not actively working on it. There are also file names falling into that pattern, see the updated top post.

    Thanks 😍 I'm on it.

  8. ViktorHofer
    assigned
    ArminShoeibi
    on May 26, 2022
  9. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on May 27, 2022
  10. am11
    removed
    untriagedNew issue has not been triaged by the area owner
    on May 30, 2022

  11. ArminShoeibi commented on Jul 1, 2022

    @ArminShoeibi
    ArminShoeibi
    on Jul 1, 2022
    Contributor

    Hello there Stephen @stephentoub, I want to delete Net5 from this class

    runtime/src/libraries/System.Private.CoreLib/src/System/Random.Net5CompatImpl.cs

    Line 16 in 7b89c86

    private sealed class Net5CompatSeedImpl : ImplBase

    could you please tell me the proper name for this class

  12. danmoseley commented on Jul 1, 2022

    @danmoseley
    danmoseley
    on Jul 1, 2022
    Contributor

    could you please tell me the proper name for this class

    I suggest to leave that one alone as it's special - specifically for back compat.

    Thanks for tackling this - my suggestion is to put renames in a different PR to content changes, for ease of review. In general, smaller PRs get merged more quickly.

  13. stephentoub commented on Jul 1, 2022

    @stephentoub
    stephentoub
    on Jul 1, 2022
    Member

    could you please tell me the proper name for this class

    I suggest to leave that one alone as it's special - specifically for back compat.

    Yes, this one is saying that it provides the same behavior as .NET 5 and earlier. It should remain.

  14. ArminShoeibi commented on Jul 1, 2022

    @ArminShoeibi
    ArminShoeibi
    on Jul 1, 2022
    Contributor

    could you please tell me the proper name for this class

    I suggest to leave that one alone as it's special - specifically for back compat.

    Thanks for tackling this - my suggestion is to put renames in a different PR to content changes, for ease of review. In general, smaller PRs get merged more quickly.

    Ok I got it Dan.

  15. ArminShoeibi commented on Jul 1, 2022

    @ArminShoeibi
    ArminShoeibi
    on Jul 1, 2022
    Contributor

    I'm going to skip these files:

    src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/AsyncServiceScope.cs
    src/installer/tests/Assets/TestProjects/PortableTestApp/PortableTestApp.csproj
    src/installer/tests/Assets/TestProjects/StandaloneTestApp/StandaloneTestApp.csproj
    src/libraries/System.Private.CoreLib/src/System/Random.Net5CompatImpl.cs
    src/libraries/System.Private.CoreLib/src/System/Random.cs
    src/native/corehost/bundle/header.h

    src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonReaderTest.cs

    src/libraries/Microsoft.Extensions.FileProviders.Composite/tests/MockFileProvider.cs

  16. ArminShoeibi commented on Jul 1, 2022

    @ArminShoeibi
    ArminShoeibi
    on Jul 1, 2022
    Contributor

    I need some guidance with these two files.

    runtime/src/libraries/Microsoft.Extensions.Hosting/tests/FunctionalTests/IntegrationTesting/src/Common/Tfm.cs

    Line 16 in 19811c2

    public const string NetCoreApp50 = "net5.0";

    runtime/src/libraries/Microsoft.Extensions.Hosting/tests/FunctionalTests/ShutdownTests.cs

    Line 66 in 19811c2

    TargetFramework = Tfm.NetCoreApp50,

    Should I change these two to NetCoreApp60?

  17. agocke
    added this to Runtime Infraon Jul 1, 2022
  18. BruceForstall
    added this to the 8.0.0 milestone on Aug 16, 2022

  19. BruceForstall commented on Aug 16, 2022

    @BruceForstall
    BruceForstall
    on Aug 16, 2022
    Contributor

    @ArminShoeibi Are you still working on this?

  20. elinor-fung
    closed this as completedin #69911on Oct 27, 2022
  21. elinor-fung
    moved this to Done in Runtime Infraon Oct 27, 2022
  22. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Oct 27, 2022
  23. ghost locked as resolved and limited conversation to collaborators on Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-Infrastructure

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions