Test failure JIT\\HardwareIntrinsics\\Arm\\AdvSimd.Arm64\\AdvSimd.Arm64_Part2_r\\AdvSimd.Arm64_Part2_r.cmd #65281

Activity

1. VincentBu

   added

   arch-arm64

   os-linuxLinux OS (any supported distro)Linux OS (any supported distro)

   os-windows

   blocking-outerloopBlocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runsBlocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs

   on Feb 14, 2022
2. ghost added

   area-ReadyToRun

   on Feb 14, 2022
3. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Feb 14, 2022
4. echesakov commented on Feb 14, 2022

   

   echesakov

   on Feb 14, 2022

   Last edited by echesakov

   Contributor

   More actions

   Here is a simplest program I managed to create to reproduce the issue (also pushed it to my clone of the repo - 14bce9a)

   // Licensed to the .NET Foundation under one or more agreements.
   // The .NET Foundation licenses this file to you under the MIT license.
   
   using System.Runtime.InteropServices;
   using System.Runtime.Intrinsics;
   
   class Runtime_63856
   {
       [StructLayout(LayoutKind.Auto)]
       struct int8x16x2
       {
           Vector128<byte> _0;
           Vector128<byte> _1;
       }
   
       struct Wrapper
       {
           int8x16x2 fld;
       }
   
       static int Main()
       {
           var val = default(Wrapper);
   
           return 100;
       }
   }

   Note that [StructLayout(LayoutKind.Auto)] is required to trigger the issue (ValueTuple<T1,T2> in the failing tests also has the attribute).

   When running on Arm64 with

   RunCrossgen2=1
   

   this will fail the following way

   X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856>Runtime_63856\Runtime_63856.cmd
   BEGIN EXECUTION
   Runtime_63856.dll
           1 file(s) copied.
   Could Not Find X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856\Runtime_63856\IL-CG2\composite-r2r.dll
   Could Not Find X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856\Runtime_63856\Runtime_63856.dll.rsp
   Response file: X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856\Runtime_63856\\Runtime_63856.dll.rsp
   X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856\Runtime_63856\IL-CG2\Runtime_63856.dll
   -o:X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856\Runtime_63856\\Runtime_63856.dll
   --targetarch:arm64
   --verify-type-and-field-layout
   --method-layout:random
   -r:X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\Tests\Core_Root\System.*.dll
   -r:X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\Tests\Core_Root\Microsoft.*.dll
   -r:X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\Tests\Core_Root\mscorlib.dll
   -r:X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\Tests\Core_Root\netstandard.dll
   -O
   " "dotnet" "X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\Tests\Core_Root\crossgen2\crossgen2.dll" @"X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856\Runtime_63856\\Runtime_63856.dll.rsp"   -r:X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856\Runtime_63856\IL-CG2\*.dll"
   Emitting R2R PE file: X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\JIT\Regression\JitBlue\Runtime_63856\Runtime_63856\\Runtime_63856.dll
    "X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\Tests\Core_Root\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  Runtime_63856.dll
   Type Wrapper: expected alignment 0x00000008, actual 0x00000010
   
   Assert failure(PID 34016 [0x000084e0], Thread: 35932 [0x8c5c]): Verify_TypeLayout 'Wrapper' failed to verify type layout
   
   CORECLR! LoadDynamicInfoEntry + 0xF18 (0x00007fff`79520c68)
   CORECLR! Module::FixupNativeEntry + 0x6C (0x00007fff`794a1abc)
   CORECLR! Module::FixupDelayListAux<Module *,int (__cdecl Module::*)(CORCOMPILE_IMPORT_SECTION *,unsigned __int64,unsigned __int64 *,int)> + 0x194 (0x00007fff`795e03a4)
   CORECLR! ReadyToRunInfo::GetEntryPoint + 0x2F4 (0x00007fff`795e1534)
   CORECLR! MethodDesc::GetPrecompiledR2RCode + 0x38 (0x00007fff`7957b768)
   CORECLR! MethodDesc::GetPrecompiledCode + 0x28 (0x00007fff`7957b540)
   CORECLR! MethodDesc::PrepareILBasedCode + 0x2A0 (0x00007fff`7957d3d8)
   CORECLR! MethodDesc::PrepareCode + 0x54 (0x00007fff`7957d12c)
   CORECLR! CodeVersionManager::PublishVersionableCodeIfNecessary + 0x2AC (0x00007fff`794c705c)
   CORECLR! MethodDesc::DoPrestub + 0x344 (0x00007fff`79579074)
       File: D:\echesako\src\runtime3\src\coreclr\vm\jitinterface.cpp Line: 13513
       Image: X:\echesako\src\runtime3\artifacts\tests\coreclr\windows.arm64.checked\Tests\Core_Root\corerun.exe
   
   Expected: 100
   Actual: -1073740286
   END EXECUTION - FAILED
   FAILED
   
5. echesakov commented on Feb 14, 2022

   

   echesakov

   on Feb 14, 2022

   Contributor

   More actions

   @mangod9 Can someone on your team take a look at this issue?
   I propose disabling the failing tests under R2R-GC2 and submitted PR last week to do this (#65227).
6. echesakov

   added

   disabled-testThe test is disabled in source code against the issueThe test is disabled in source code against the issue

   on Feb 14, 2022
7. echesakov

   added a commit that references this issue on Feb 14, 2022

   Add regression tests for dotnet#65281

   14bce9a
8. mangod9 commented on Feb 14, 2022

   

   mangod9

   on Feb 14, 2022

   Member

   More actions

   @AaronRobinsonMSFT @davidwrighton if this is a new failure is it related to the ref fields work?
9. JulieLeeMSFT

   assigned

   mangod9

   on Jun 13, 2022
10. trylek

    added this to the 7.0.0 milestone on Jun 14, 2022
11. ghost removed

    untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

    on Jun 14, 2022
12. mangod9 commented on Aug 3, 2022

    

    mangod9

    on Aug 3, 2022

    Member

    More actions

    @davidwrighton is this something you could look into since its related to intrinsics?
13. mangod9

    assigned

    davidwrighton

    and unassigned

    mangod9

    on Aug 4, 2022
14. davidwrighton commented on Aug 9, 2022

    

    davidwrighton

    on Aug 9, 2022

    Member

    More actions

    This isn't intrinsics, this is struct layout, but fortunately enough while this failure is enough to break the test, it shouldn't actually break customers. However, lack of testing of the intrinsics is a problem so it does need to be fixed.
15. davidwrighton commented on Aug 11, 2022

    

    davidwrighton

    on Aug 11, 2022

    Member

    More actions

    Ok, this is actually a general purpose AutoLayout bug impacting the alignment calculations for structures. We were improperly computing a the wrong alignment in a number of scenarios. (Sometimes too high, sometimes too low.). Given the general lack of autolayout structures, this probably isn't a terribly impacting bug, but it likely does reduce the set of functions that can be used out of an R2R image if ValueTuple is used, and for applications which hold ValueTuple within the version bubble of the app, larger problems may arise. (Also its a problem if ValueTuple starts being used in CoreLib.)
16. davidwrighton

    added a commit that references this issue on Aug 11, 2022

    Fix auto layout algorithm to compute structure alignment correctly

    ...

    This issue will close once commit be730bc is merged into the 'main' branch.

    be730bc
17. ghost added

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Aug 11, 2022
18. davidwrighton

    closed this as completedin #73738on Aug 17, 2022
19. davidwrighton

    added a commit that references this issue on Aug 17, 2022

    Fix auto layout algorithm to compute structure alignment correctly (#…

    ...

    This issue will close once commit 2fc2241 is merged into the 'main' branch.

    2fc2241
20. ghost removed

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Aug 17, 2022
21. github-actions

    added a commit that references this issue on Aug 17, 2022

    Fix auto layout algorithm to compute structure alignment correctly - …

    ...

    This issue will close once commit d653019 is merged into the 'main' branch.

    d653019
22. carlossanlop

    added a commit that references this issue on Aug 18, 2022

    [release/7.0-rc1] Fix auto layout algorithm to compute structure alig…

    ...

    This issue will close once commit a969995 is merged into the 'main' branch.

    a969995
23. ghost locked as resolved and limited conversation to collaborators on Sep 16, 2022