Repository navigation
[wasm][debugger] DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment failing #64188
Description
Failing on rolling build - Build, and Log
[21:35:25] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] New test request
[21:35:25] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] launching proxy for ws://127.0.0.1:37767/devtools/page/79E663E76834EA440CBAB0CD2CAB2BDB
[21:35:25] info: DebuggerTests.Inspector[0] waiting for the runtime to be ready
[21:35:27] info: DebuggerTests.Inspector[0] runtime ready, TEST TIME
[21:35:27] info: DebuggerTests.Inspector[0] console.log: ready
[21:35:27] fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-:::9 -> [Result: IsOk: False, IsErr: True, Value: , Error: { "message": "Unable to RuntimeGetProperties 'dotnet:scope:1'" } ]
[21:35:27] info: DebuggerTests.Inspector[0] console.trace: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met
[21:35:27] info: DebuggerTests.Inspector[0] console.error: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] RunLoop stopped, reason: Shutdown. (parentToken: True, linked: True):
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] Failing 0 pending cmds
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] Loop ended with socket: Aborted
[21:35:27] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] Proxy done
[xUnit.net 00:00:15.58] DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]]) [FAIL]
[21:35:28] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] connecting to ws://localhost:9400/launch-chrome-and-connect
[21:35:28] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] New test request
[21:35:28] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] launching proxy for ws://127.0.0.1:36459/devtools/page/1075ADF29D9088A2E8B9BF6E78493EBB
[21:35:28] info: DebuggerTests.Inspector[0] waiting for the runtime to be ready
Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]]) [153 ms]
Error Message:
[Runtime.getProperties returned False instead of True, for {
"objectId": "dotnet:scope:1"
}, with Result: [Result: IsOk: False, IsErr: True, Value: , Error: {
"message": "Unable to RuntimeGetProperties 'dotnet:scope:1'"
} ]]
Expected: True
Actual: False
Stack Trace:
at DebuggerTests.DebuggerTestBase.AssertEqual(Object expected, Object actual, String label) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1058
at DebuggerTests.DebuggerTestBase.GetProperties(String id, JToken fn_args, Nullable`1 own_properties, Nullable`1 accessors_only, Boolean expect_ok) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 835
at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 512
at DebuggerTests.DebuggerTestBase.StepAndCheck(StepKind kind, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, Int32 times) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 472
at DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(String clazz, JObject checkDefault, JObject checkValue) in /_/src/mono/wasm/debugger/DebuggerTestSuite/AssignmentTests.cs:line 48
--- End of stack trace from previous location ---
The runtime is asserting at https://github.com/dotnet/runtime/blob/main/src/mono/mono/component/debugger-agent.c#L2195:
...
[21:35:27] info: DebuggerTests.Inspector[0] console.trace: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met
[21:35:27] info: DebuggerTests.Inspector[0] console.error: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met
...
This was hit on the rolling build for 4a6d169 but was working on the previous build for 5605bdf , and the new commit being: 4a6d169
Add runtime support for ref fields (#63985)
* Add mono and coreclr runtime support for ref fields
* Update Reflection.Emit tests to validate ref fields.
Add test for TypedReference as a ref field.
{
"ErrorMessage": "Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment",
"BuildRetry": false
}Report
Summary
| 24-Hour Hit Count | 7-Day Hit Count | 1-Month Count |
|---|---|---|
| 1 | 6 | 20 |
Activity
AaronRobinsonMSFT commentedon Jan 24, 2022
@lambdageek or @fanyang-mono I'm going to need some help here. I've no idea why the
reffield changes would have impacted a test related to debugger stepping around enum assignment. The test that is failing isruntime/src/mono/wasm/debugger/DebuggerTestSuite/AssignmentTests.cs
Line 42 in d964b63
The code being executed under that test is
runtime/src/mono/wasm/debugger/tests/debugger-test/debugger-assignment-test.cs
Lines 158 to 165 in d964b63
radical commentedon Jan 24, 2022
Cc @thaystg
thaystg commentedon Jan 24, 2022
I'm working on it.
thaystg commentedon Jan 24, 2022
@AaronRobinsonMSFT it's possibly unrelated with that commit. Still working on it.
radical commentedon Jan 24, 2022
I didn't see the failure on the subsequent rolling build, so removing
blocking-clean-cilabel.radical commentedon Jan 30, 2022
Seeing this on windows too - log.
12 remaining items
radical commentedon Oct 4, 2022
This is being hit again, but with a different error:
Also here.
[wasm] Disable failing debugger test
[wasm] Disable failing debugger test (#76667)
radical commentedon Nov 15, 2022
@missymessa I looked at the top few builds referenced in the Report (in the PR description), and I don't see the failure
"ErrorMessage": "DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment". None of them had this failure but they still show up here. What is it matching then? (I did look at the previous attempts too)Example - https://dev.azure.com/dnceng-public/public/_build/results?buildId=82673&view=results, and https://dev.azure.com/dnceng-public/public/_build/results?buildId=82735&view=results.
ulisesh commentedon Nov 28, 2022
The error message has to improve, build analysis will match this known issue with any failed build or test that contains the string
DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment. For example, this buildA better error message would be
Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignmentradical commentedon Jun 1, 2023
I have removed the
known build errorlabel because we don't have a unique string to match this error. The current one being used matches any failure in this test, and that can end up covering other unrelated genuine failures.lewing commentedon Jul 10, 2023
@thaystg what is the status on this one?
thaystg commentedon Jul 11, 2023
I will close this one, me and @radical haven't seen this recently.