镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Some repos do not contribute to third-party-notices file #61466

Closed

Description

@NikolaMilosavljevic

Here's a list of repos that should contribute to the shipping third-party-notices file, but that don't have their TPN file established in their repos.

We need to work with each repo owner to establish and maintain their TPN files. Once that is changed, our TPN generation infra (in PR: #60091) should be updated.

Additional repos that should be included but don't have any third-party-notices files:

  • dotnet/efcore - confirmed, no 3p code
  • dotnet/emsdk - content likely needed
  • dotnet/icu - content likely needed Add TPN for ICU icu#200
  • dotnet/extensions - under the Runtime and ASPNet repos and covered by those TPNs
  • dotnet/sdk - possibly covered by dotnet/installer TPN
  • dotnet/windowsdesktop - confirmed, no 3p src in WinForms or WPF shipping assets
  • dotnet/linker - will be resolved by Add license header to files that have no header linker#2469

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Nov 11, 2021
  2. NikolaMilosavljevic commented on Nov 17, 2021

    @NikolaMilosavljevic
    ContributorAuthor

    [Triage] @leecow is this something you were tracking and can be enabled early in 7.0 so we have all contributing repos onboarded on time?

  3. leecow commented on Nov 17, 2021

    @leecow
    Member

    Yes, I can track and work with the missing repos.

  4. danmoseley commented on Mar 23, 2022

    @danmoseley
    Contributor

    @NikolaMilosavljevic did you get a chance to reach out?

  5. NikolaMilosavljevic commented on Mar 23, 2022

    @NikolaMilosavljevic
    ContributorAuthor

    @NikolaMilosavljevic did you get a chance to reach out?

    @leecow was going to work with missing repos. @leecow were there any updates, should we have an issue for each repo to create TPN file, so we can harvest it and include relevant notices in the shipping file?

  6. leecow commented on Mar 23, 2022

    @leecow
    Member

    Sorry, fell off the plate. I like the idea of individual issues which I can open in the repos listed above. Will also communicate with owners internally to give them a heads up.

    @NikolaMilosavljevic - To make sure I understand the need - do the repos need to host a TPN doc like this, or something else?

  7. RussKie commented on Mar 28, 2022

    @RussKie
    Contributor

    Windows Forms do not use any 3rd party dependencies (i.e., non Microsoft) in the production code (i.e., the code we ship in Windows Desktop). Standing by for the WPF sign off from @singhashish-wpf to complete the Windows Desktop story.

  8. added a commit that references this issue on Mar 30, 2022
  9. added a commit that references this issue on Apr 8, 2022
  10. added this to the 7.0.0 milestone on Aug 17, 2022
  11. NikolaMilosavljevic commented on Aug 25, 2022

    @NikolaMilosavljevic
    ContributorAuthor

    @leecow is there any pending work for the last remaining repo dotnet/emsdk?

    We need to update main third-party-notices file, which will harvest TPNs from all dependent repos - #74605

  12. NikolaMilosavljevic commented on Aug 29, 2022

    @NikolaMilosavljevic
    ContributorAuthor

    Removing 'blocking-release' label - we are updating TPN notices for 7.0 with #74760

  13. leecow commented on Aug 29, 2022

    @leecow
    Member

    @lewing - anything in emsdk that needs to be covered by a third-party license notice?

  14. NikolaMilosavljevic commented on Aug 31, 2022

    @NikolaMilosavljevic
    ContributorAuthor

    Moving to 8.0 - we've updated TPN file for 7.0 release with: #74760

  15. ghost locked as resolved and limited conversation to collaborators on Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions