镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Validate the Cosmos session token management mode - #39658

Open
ilkertskn wants to merge 1 commit into
dotnet:mainfrom
ilkertskn:fix/cosmos-session-token-mode-undefined-value
Open

ilkertskn wants to merge 1 commit into
dotnet:mainfrom
ilkertskn:fix/cosmos-session-token-mode-undefined-value

Conversation

@ilkertskn

Copy link
Copy Markdown
Contributor

WithConnectionMode rejects values that aren't defined in ConnectionMode, but WithSessionTokenManagementMode stored any value. An undefined mode was then treated by SessionTokenStorage as neither fully automatic nor one of the manual modes: tokens were tracked and sent, and the manual session token APIs were enabled, a behavior that no mode describes.

Throw ArgumentOutOfRangeException for undefined values, as for ConnectionMode.

  • [x ] I've read the guidelines for contributing and seen the walkthrough
  • [x ] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [x ] The code builds and tests pass locally (also verified by our automated build checks)
  • [x ] Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • [x ] Tests for the changes have been added (for bug fixes / features)
  • [x ] Code follows the same patterns and style as existing code in this repo

WithConnectionMode rejects values that aren't defined in ConnectionMode,
but WithSessionTokenManagementMode stored any value. An undefined mode
was then treated by SessionTokenStorage as neither fully automatic nor
one of the manual modes: tokens were tracked and sent, and the manual
session token APIs were enabled, a behavior that no mode describes.

Throw ArgumentOutOfRangeException for undefined values, as for
ConnectionMode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant