Repository navigation
Throw for out-of-range SQL Server TimeSpan literals - #39364
Merged
AndriySvyryd merged 1 commit intoOct 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified, and the supplied assessments unanimously support approval.
No open issues 🎉
1 file not reviewed
src/EFCore.SqlServer/Properties/SqlServerStrings.Designer.cs: Generated file
What changed in this PR
This pull request validates SQL Server TimeSpan literals against the supported time range, preventing invalid values from being generated as SQL.
Changes:
- Rejects negative and 24-hour-or-longer
TimeSpanliterals. - Adds a localized resource-based overflow message.
- Adds regression coverage for invalid values, boundary values, and query translation.
| File | Description |
|---|---|
test/EFCore.SqlServer.Tests/Storage/SqlServerTypeMappingTest.cs |
Covers invalid literals, valid boundaries, and query translation behavior. |
src/EFCore.SqlServer/Storage/Internal/SqlServerTimeSpanTypeMapping.cs |
Validates TimeSpan values before generating SQL literals. |
src/EFCore.SqlServer/Properties/SqlServerStrings.resx |
Defines the localized out-of-range literal error message. |
src/EFCore.SqlServer/Properties/SqlServerStrings.Designer.cs |
Exposes the generated resource accessor. |
Review effort: Lite
AndriySvyryd
approved these changes
Oct 22, 2026
AndriySvyryd
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39222
Summary
timerange.Tests