Repository navigation
Document SYSLIB1219 options validation diagnostic - #56288
Merged
Merged
Conversation
gewarren
approved these changes
Oct 2, 2026
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
enabled auto-merge (squash)
October 2, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56285.
Adds the missing SYSLIB1219 row to the options-validation source-generator diagnostics table. The wording follows the existing SYSLIB1205 row for Validate, using ValidateAsync for its async counterpart.
Checked the diagnostic descriptor in dotnet/runtime's Microsoft.Extensions.Options generator, which defines SYSLIB1219 as AlreadyImplementsValidateAsyncMethod. The SYSLIB1218 keyword is left unchanged because its intended use has not been confirmed.
Validation: inspected the rendered Markdown and verified that the diff is one table-row addition. No product code changed.
Internal previews
Build report