Repository navigation
Breaking change: IsTrimmable for netstandard libs - #36775
Merged
Merged
Conversation
gewarren
approved these changes
Aug 21, 2023
gewarren
left a comment
Collaborator
There was a problem hiding this comment.
I would probably also put all mentions of "netstandard" in backticks.
vitek-karas
reviewed
Aug 22, 2023
Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
- Use .NET Standard instead of netstandard - Also mention .NET Framework Also makes the description more thorough by mentioning PublishTrimmed and PublishAot.
Member
Author
|
I replaced "netstandard" with ".NET Standard", and am using ".NET Framework" to refer to TFMs like |
vitek-karas
approved these changes
Aug 24, 2023
25 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a breaking change notice about the new behavior of
IsTrimmablefor netstandard libraries.Fixes dotnet/sdk#30948
Note: I only described the behavior that is shipping in RC1, and listed RC1 as the version that introduced the change. P7 actually introduced the first breaking change, but with slightly different behavior (different code, different message, and it was an error instead of a warning).
Internal previews