Repository navigation
Print help when a diagnostics tool is run without a command - #6132
Merged
Merged
Conversation
The root commands have subcommands but no action, so running a tool with no arguments failed with 'Required command was not provided.' Give each root command a HelpAction instead. Fixes dotnet#510
rcj1
approved these changes
Oct 23, 2026
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #510
Running any of the tools with no arguments printed
Required command was not provided.and exited with 1, because the root command has subcommands but no action. The System.CommandLine limitation mentioned in the issue (dotnet/command-line-api#653) is gone in the 2.0 API, so the root command can now be givenHelpAction.The change is the same one line in each tool: dotnet-counters, dotnet-trace, dotnet-dump, dotnet-gcdump, dotnet-stack, dotnet-dsrouter and dotnet-sos.
Checked each built tool by hand:
bogus(unknown command)--versionUnknown commands and other parse errors still fail as before.