Repository navigation
Drop MonoPackageManager for APIs older than 9 - #2691
Merged
Merged
Conversation
Context: dotnet#2690 Fixes: dotnet#2690 Xamarin.Android and Mono are no longer capable of running on API levels lower than 9 (if built with NDK r14) or 16 (if built with NDK r18+). This commit drops the version of `MonoPackageManager` targetting API levels < 9. If an application with its minimum target sdk set to anything < 9 is build it results in a compilation error when building Java code: error : error: method init in class Runtime cannot be applied to given types; [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] error : Runtime.init ( [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] error : required: String,String[],String,String[],ClassLoader,String[],String[],String,int,String[] [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] error : found: String,String[],String,String[],ClassLoader,String[],String[],String [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] error : reason: actual and formal argument lists differ in length [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] This is caused by the changes introduced in the runtime performance commit dotnet@b90d3ab which changed the `Runtime.init` signature but *only* in the version of `MonoPackageManager` targetting the currently supported minimum SDK levels.
grendello
requested review from
dellis1972 and
jonathanpeppers
as code owners
February 4, 2019 18:34
jonathanpeppers
approved these changes
Feb 4, 2019
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
Looks good I don't see anything else using this file in xamarin-android or monodroid.
jonpryor
pushed a commit
that referenced
this pull request
Feb 6, 2019
Xamarin.Android and Mono are no longer capable of running on API levels lower than 9 (if built with NDK r14) or 16 (if built with NDK r18+). This commit drops the version of `MonoPackageManager` targeting API levels < 9. If an application with its minimum target sdk set to anything < 9 is built it results in a compilation error when building Java code: error : error: method init in class Runtime cannot be applied to given types; [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] error : Runtime.init ( [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] error : required: String,String[],String,String[],ClassLoader,String[],String[],String,int,String[] [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] error : found: String,String[],String,String[],ClassLoader,String[],String[],String [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] error : reason: actual and formal argument lists differ in length [C:\xms\NPlus1DaysOfMvvmCross\N-04-ValueConverters\Value.Droid\Value.Droid.csproj] This is caused by the changes introduced in the runtime performance commit b90d3ab which changed the `Runtime.init()` signature but *only* in the version of `MonoPackageManager` targeting the currently supported minimum SDK levels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #2690
Fixes: #2690
Xamarin.Android and Mono are no longer capable of running on API levels lower
than 9 (if built with NDK r14) or 16 (if built with NDK r18+). This commit drops
the version of
MonoPackageManagertargetting API levels < 9.If an application with its minimum target sdk set to anything < 9 is build it
results in a compilation error when building Java code:
This is caused by the changes introduced in the runtime performance commit
b90d3ab
which changed the
Runtime.initsignature but only in the version ofMonoPackageManagertargetting the currently supported minimum SDK levels.