Repository navigation
[Microsoft.Android.Build.Tasks] Recognize low-storage install errors - #13555
Open
jonathanpeppers wants to merge 2 commits into
Open
jonathanpeppers wants to merge 2 commits into
jonathanpeppers wants to merge 2 commits into
Conversation
Android can report low storage as a Java IOException instead of an INSTALL_FAILED_INSUFFICIENT_STORAGE result. Match this message to ADB0060 without retrying or uninstalling, and keep the original output. Add regression cases for the exception with zero and nonzero exit codes, and update the ADB0060 documentation. Fixes #13253. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Treat the install exception header as a generic failure even when adb returns exit code zero. Keep the storage-specific check ahead of this fallback and match its message without requiring a Java exception type. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change recognizing Android low-storage installation exceptions as ADB0060.
No open issues 🎉
What changed in this PR
Addresses #13253 by recognizing Android’s low-storage installation exception as ADB0060, giving users a clearer diagnostic during fast deployment.
Changes:
- Classifies the low-storage exception as insufficient space, including when
adbexits with code zero. - Extends regression tests to verify diagnostic output is preserved without retrying or uninstalling.
- Updates ADB0060 documentation to describe the exception and current fast-deployment behavior.
| File | Description |
|---|---|
| src/Microsoft.Android.Build.Tasks/Tests/Microsoft.Android.Build.Tasks.Tests/FastDeployTests.cs | Expands storage-error and unrelated-exception test cases. |
| src/Microsoft.Android.Build.Tasks/Tasks/FastDeploy.Adb.cs | Recognizes the low-storage exception text. |
| Documentation/docs-mobile/messages/adb0060.md | Documents the additional error form and corrects implementation notes. |
Review effort: Balanced
simonrozsival
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13253.
Android can report
Requested internal only, but not enough spaceinstead ofINSTALL_FAILED_INSUFFICIENT_STORAGE. Fast deployment reports this as ADB0010, or treats it as success if the exit code is zero.Map the storage message to ADB0060 without requiring a particular Java exception type. Treat
Exception occurred while executing 'install'as a generic ADB0010 failure when no specific error matches, even with exit code zero. Preserve the original output without retrying or uninstalling.Tested with the locally provisioned .NET 12 SDK:
.\bin\Debug\dotnet\dotnet.exe test src\Microsoft.Android.Build.Tasks\Tests\Microsoft.Android.Build.Tasks.Tests\Microsoft.Android.Build.Tasks.Tests.csproj -v minimal --filter "FullyQualifiedName~FastDeployTests"27 passed; 39 existing bash-based tests skipped on Windows. Regression cases cover storage errors with and without the Java exception type, zero and nonzero exit codes, and unrelated install exceptions. No low-storage device test was run.