Repository navigation
Sanitize Xamarin.Android.sln: fix several inconsistency bits. - #1159
Merged
Merged
Conversation
Manually editing solution file is uncool and error prone, but since the entire xamarin-android source tree is not designed cleanly it is impossible to use IDEs to do the right job. As stated at dotnet#1129 , we should eliminate this Xamarin.Android.sln as a source file and it should be only generated, not directly committed to the tree. But to achieve that we first need to find the right structure and right content. So far, there were handful of issues that either missed or incorrectly added solution items with inconsistent configurations. These inconsistent parts were found by the solution content analyzer at dotnet#1129 (comment)
Contributor
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually editing solution file is uncool and error prone, but since the
entire xamarin-android source tree is not designed cleanly it is impossible
to use IDEs to do the right job.
As stated at #1129 ,
we should eliminate this Xamarin.Android.sln as a source file and it should
be only generated, not directly committed to the tree. But to achieve that
we first need to find the right structure and right content.
So far, there were handful of issues that either missed or incorrectly
added solution items with inconsistent configurations.
These inconsistent parts were found by the solution content analyzer at
#1129 (comment)