镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix: enable discussion and discussion_comment events in app manifest - #1

Open
m1lo9 wants to merge 1 commit into
devlikeapro:masterfrom
m1lo9:fix-enable-discussion-events
Open

m1lo9 wants to merge 1 commit into
devlikeapro:masterfrom
m1lo9:fix-enable-discussion-events

Conversation

@m1lo9

@m1lo9 m1lo9 commented Aug 5, 2026

Copy link
Copy Markdown

Problem

Handlers for discussion badges (handleDiscussionAddBadge, handleDiscussionCommentAddBadge) were already implemented in src/handlers/badges.ts and registered in src/index.ts, but the corresponding events were commented out in app.yml, so the app never received these webhooks.

Fix

Uncommented the discussion and discussion_comment events in app.yml so they match the handlers that already exist in the codebase.

Note for maintainer

This PR only updates the app.yml manifest file, which serves as a reference/template — as noted in the file's own comment, changing it does not automatically update the live GitHub App configuration. To actually enable these handlers in production, please also manually enable the discussion and discussion_comment events under Settings → Permissions & events → Subscribe to Events on the app's settings page, then click Save changes.

Handlers for discussion badges (handleDiscussionAddBadge,
handleDiscussionCommentAddBadge) were already implemented in
src/handlers/badges.ts and registered in src/index.ts, but the
corresponding events were commented out in app.yml, so the app
never received these webhooks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant