Repository navigation
Standing block for decisions/ma-do (#762) - #805
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #805 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4642 4642
=======================================
Hits 4598 4598
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
derek73
added a commit
that referenced
this pull request
Oct 22, 2026
…ved example, rules/S1's ambiguous-member exception (#807) * Fix two stale design-doc claims PR #805's review found decisions/S7: the 2026-09-27 #544 entry's example `doe, jane v phd do` read suffix 'v phd do' when written; since #721 (PR #722) the one-case `v` is an initial, which ends the credential run, so the name reads middle 'v', suffix 'phd do'. The head now names the superseded reading, in the shape decisions/H3 uses for #718. rules/S1: add an Except bullet for a member of the ambiguous class written without periods, which keeps a bracketed clause a nickname (`John Smith (MA)`), an exception recorded until now only in decisions/suffix-acronym-collisions. S1's budget re-recorded (words 92 -> 161, except 0 -> 1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Add S1's new examples to the rules corpus and the snapshot Three new names, no moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Narrow S1's Except to a one-word clause; mark S7's other stale copies Review of the first commit: S1 tests the whole clause, so the exception is a clause that IS one ambiguous member not ending in a period, not a member anywhere in it ((MA Jr.) and (PhD MA.) escape; (PhD MBA) never does). The (PhD MA) row witnessed the multi-word reason, not the member, and is replaced by PhD (MA), which pins S7's company not reaching in. The dotted spelling escapes by its final period, not by S3: (M.A) stays a nickname. decisions/S7's other #544 entry stated the moved reading in its (7) and its 2026-09-28 addendum; its head now says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Restore 'written without periods' to S1's Except lead The second review: dropping it widened the lead to interior-period spellings, (M.A) and (M.Eng), which stay nicknames with nothing reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Narrow S1 to what the parser does: quotes, and multi-word clauses Derek's call on #807's follow-ups. S1's When now names quotes beside brackets, since every default nickname pair escapes the same way ("MBA" -> suffix, "MA" -> nickname). A new Except bullet: a clause of two or more words is a nickname whatever it holds, nothing reported, unless it ends in a period ((PhD MBA) -> nickname, as 1.4.0 read it). _extract's citation of S1's Then follows the new wording. S1's budget re-recorded; three new rules-corpus names, no moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Scope S1's new Except to what it reads; record the narrowing Review of the narrowing commit: the multi-word bullet's 'nothing is reported' was false for an ambiguous member in the clause ((MA PhD) reports), its 'is a nickname' contested M3's marker-led clauses and was false under a declared maiden pair, and 'ends in a period' is an ASCII period last before the closer. The bullet now says the clause is not suffix-shaped and reads as its pair reads it; the member bullet says it is reported wherever it stands in a nickname; a Precedence bullet gives M3 the marker-led clause. New decisions/S1 records Derek's call, with Standing and an Elsewhere line, and S1 gains its history pointer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix S1's M3 Precedence lead, a misplaced row, and decisions/S1 scope Second review: the Precedence lead 'a marker-led clause of two or more words' took (née Jr.) from the bullet above and covered clauses M3 never takes ((z domu), (née , Jones)); it is now 'a clause M3 reads as a maiden name'. The (MA PhD) row moves to the multi-word fence. In decisions/S1, 1.4.0 parity holds for the ASCII quotes only, the typographic and CJK pairs being 2.x additions, and the Elsewhere pointer names the one Standing line it means. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #762. Gives
decisions/ma-do.mda## Standingblock and a## Logheading, and takesma-doofftests/v2/decisions_without_standing.json, ahead of #752 (which rewrites the ambiguous-acronym marking this file records).Standing lines, each measured on the tree under all three name orders: set membership (
ma/do), the #289 all-caps lean (Jack MA/Jack DO), the dotted spellings, the parenthesized(MA)/(DO)nickname reading, anddoafter a family comma (#531). The first log entry's head notes that itsJack Masentence is superseded in part by #289. Everything decided in other files (the Title-case/all-lower/one-case reading, the particle-run and credential-in-front exceptions, the suffix-comma reach, the S1 bracket escape) is anElsewhere:line, not a bullet.Open: #792is noted.Two Opus
design-docs-reviewerrounds: round one found a case-lean line claiming more than #289 decided (two later exceptions missed), a family-first gap, an ambiguous S5 pointer and a missing S6 #761 pointer; round two found my family-first sentence over-claimed (only Title-caseDoattaches comma-less under FAMILY_FIRST), a misplaced #792 sentence, and two Elsewhere pointers matching more than one entry. All fixed.Stale, found but left out of this PR (a separate session is fixing both; no PR for it yet at the time of writing):
John Smith, PhD MEngreads firstPhD, lastJohn Smith#544 entry ("THE ShouldDoe, John MAreadMAas a credential, as 1.4.0 did, or at least report the fork? #531 PAIRING GAINS A SECOND EXCEPTION") has an example,doe, jane v phd do→ suffix 'v phd do', that parses today as middle 'v', suffix 'phd do'. Pre-existing.Tests: design-docs and citation tests pass; full suite passes on 3.11 and 3.15 (22,553 passed).
🤖 Generated with Claude Code