镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Hide tty date - #486

Closed
amejiarosario wants to merge 4 commits into
debug-js:masterfrom
amejiarosario:hide-tty-date
Closed

amejiarosario wants to merge 4 commits into
debug-js:masterfrom
amejiarosario:hide-tty-date

Conversation

@amejiarosario

@amejiarosario amejiarosario commented Aug 12, 2017 •

Copy link
Copy Markdown

This option is very needed when running Node on systems that already provides time stamps such as Heroku, PM2, systemd...

Solves #453

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 73.585% when pulling 428a07a on amejiarosario:hide-tty-date into 13e1d06 on visionmedia:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 73.585% when pulling 428a07a on amejiarosario:hide-tty-date into 13e1d06 on visionmedia:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 73.585% when pulling 428a07a on amejiarosario:hide-tty-date into 13e1d06 on visionmedia:master.

@coveralls

coveralls commented Aug 12, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.3%) to 74.051% when pulling 62589c0 on amejiarosario:hide-tty-date into 13e1d06 on visionmedia:master.

@ptusch

ptusch commented Sep 5, 2017 •

Copy link
Copy Markdown

Bump Would really love this feature as debug poisons our logs for now :s

@Qix-
Qix- requested a review from TooTallNate September 5, 2017 09:23

@Qix- Qix- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - want to make sure the other maintainers agree on adding yet another environment variable. I don't see a reason not to in this case.

@amejiarosario

amejiarosario commented Sep 5, 2017 •

Copy link
Copy Markdown
Author

Thanks! yes, as mentioned before, this env var is very needed for avoiding the double timestamps in Heroku, PM2, Systemd...

TooTallNate added a commit that referenced this pull request Sep 22, 2017
Squashed commit of the following:

commit 62589c0
Author: Adrian Mejia <admejiar@cisco.com>
Date:   Sat Aug 12 15:24:45 2017 -0400

    solves merge conflict

commit 55e5c5e
Author: Adrian Mejia <admejiar@cisco.com>
Date:   Sat Aug 12 15:21:16 2017 -0400

    docs

commit e09dec3
Author: Adrian Mejia <admejiar@cisco.com>
Date:   Sat Aug 12 15:19:10 2017 -0400

    cleanup

commit 9dd6a2b
Author: Adrian Mejia <admejiar@cisco.com>
Date:   Sat Aug 12 15:05:53 2017 -0400

    enables DEBUG_HIDE_TTY_DATE
@TooTallNate

Copy link
Copy Markdown
Contributor

Thank you! Merged in 56a3853.

@amejiarosario
amejiarosario deleted the hide-tty-date branch September 22, 2017 18:35
@amejiarosario
amejiarosario restored the hide-tty-date branch September 22, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants