Repository navigation
Conversation
Contributor
|
This is awesome! A few comments:
|
Contributor
Contributor
|
Love it! Let's get the build passing? |
Member
Author
|
@thebigredgeek https://travis-ci.org/visionmedia/debug/jobs/262103770 <- re-run that test :) You have coveralls as a part of the pass/fail steps, and coveralls likes to fail from time to time, randomly. If you re-run it, it should pass. Unless coverage going down makes tests fail. In which case, a 0.1% decrease is a bit harsh to cause a failure, no? O.o @TooTallNate can do :) |
Member
Author
|
@TooTallNate I updated the colors to be color bounded so they look better on white backgrounds. |
TooTallNate
added a commit
that referenced
this pull request
Aug 8, 2017
Like #481, but for the web browser.
TooTallNate
added a commit
that referenced
this pull request
Aug 8, 2017
Like #481, but for the web browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Only having a select few colors gets old and can make certain namespace prefixes harder to read (especially when they have similar lengths and are the same color).
This PR enables 256 colors when both of the following are true:
supports-coloris availablerequire('supports-color').level >= 2Otherwise, the color level falls back to the current selection of basic colors.
To generate the list of colors, I selected all ANSI 256 colors that satisfy the following requirements:
minof the contrast against both white and black is no less than 1.5You can use the following script to experiment:
How I personally will be using this modification is to add
supports-colorto my dev dependencies since it's not required in production. Great for local development with no overhead in prod.