镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Change bool flags to str option. #170

Open
Open
Change bool flags to str option.#170

Description

@nstarman
nstarman
opened on Aug 30, 2023

daft/src/daft/_core.py

Lines 570 to 572 in 7e859f2

observed=False,
fixed=False,
alternate=False,

can be more succinctly represented as

kind: Literal["observed", "fixed", "alternate"] | None = None

This makes it impossible to pass more than one option and still easy to check that the option is correct.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions