镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Issue with eof-newline #572

Open
Open

Description

@line47

I'd expect the results of "eof-newline": true to put a newline after every https://github.com/csscomb/csscomb.js/blob/dev/doc/options.md#eof-newline

However that is not happening when I run CSS Comb on an entire file.

Here is my config:

{
    "exclude": [
        ".git/**",
        "node_modules/**",
        "bower_components/**"
    ],
    "always-semicolon": true,
    "block-indent": "  ",
    "color-case": "lower",
    "color-shorthand": true,
    "element-case": "lower",
    "include": true,
    "eof-newline": true,
    "leading-zero": false,
    "quotes": "single",
    "remove-empty-rulesets": true,
    "space-after-colon": " ",
    "space-after-combinator": " ",
    "space-after-opening-brace": "\n",
    "space-after-selector-delimiter": "\n",
    "space-around-operator": " ",
    "space-before-closing-brace": "\n",
    "space-before-colon": "",
    "space-before-combinator": " ",
    "space-before-opening-brace": " ",
    "space-before-selector-delimiter": "",
    "space-between-declarations": "\n",
    "strip-spaces": true,
    "tab-size": true,
    "unitless-zero": true,
    "vendor-prefix-align": true,
    "sort-order": [ "..." ],
    "sort-order-fallback": "abc"
  }

Here is my SCSS before running CSS Comb:

.label-success {
  background-color: $label-success-bg-color;
}
.label-danger {
  background-color: $label-danger-bg-color;
}
.label-warning {
  background-color: $label-warning-bg-color;
}

Here is my SCSS after running CSS Comb: (no change 😢 )

.label-success {
  background-color: $label-success-bg-color;
}
.label-danger {
  background-color: $label-danger-bg-color;
}
.label-warning {
  background-color: $label-warning-bg-color;
}

What am I missing here?

Activity

  1. anton-dubrovin commented on Jan 19, 2018

    @anton-dubrovin

    Hello,
    we have the same issue with eof newline. I get css something like this:

    .ksf-field-box .ksf-field-box__title {
    	margin-bottom: 1.2em;
    
    	font-weight: 500;
    }.ksf-field-box .ksf-field-box__desc {
    	color: #989CB3;
    }.ksf-field-box .ksf-field-box__main {
    	display: flex;
    	align-items: flex-start;
    	flex-wrap: wrap;
    
    	max-width: 840px;
    	margin: -10px;
    }
    
  2. jdalton commented on Apr 26, 2019

    @jdalton
    Contributor

    Hi @line47, @kraftstudio

    Are either of you on Windows?

  3. line47 commented on Apr 26, 2019

    @line47
    Author

    Hey @jdalton not I. I'm on Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions