Repository navigation
Conversation
`.gitignore` ignores the iOS slice fixture's build output but not the Android fixtures', so running any of their Gradle projects leaves `build/` and `.gradle/` sitting in `git status` as untracked. Both are generated: `build/` is the fixture's own output, and `.gradle/` is Gradle's per-project cache, recreated on the next build. Neither belongs to whoever clones the repository. The patterns are scoped to `fixtures/*/` rather than naming each fixture, so a fixture added later is covered, while a `build/` directory elsewhere in the tree is not swept up. Checked with `git check-ignore`: - `packages/android/fixtures/vulkan-surface/build`, `.../build/outputs` and `.../.gradle` are ignored, by lines 61 and 62. - `packages/android/fixtures/vulkan-surface/build.gradle.kts` is not ignored, which is the case that matters: the fixture's build script sits next to the directory the rule names. - The existing iOS rule at line 55 still matches.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignoreignores the iOS slice fixture's build output but not the Android fixtures', so running any of their Gradle projects leavesbuild/and.gradle/sitting ingit statusas untracked.Both are generated:
build/is the fixture's own output, and.gradle/is Gradle's per-project cache, recreated on the next build. Neither belongs to whoever clones the repository.The patterns are scoped to
fixtures/*/rather than naming each fixture, so a fixture added later is covered, while abuild/directory elsewhere in the tree is not swept up. Checked withgit check-ignore:packages/android/fixtures/vulkan-surface/build,.../build/outputsand.../.gradleare ignored, by lines 61 and 62.packages/android/fixtures/vulkan-surface/build.gradle.ktsis not ignored, which is the case that matters: the fixture's build script sits next to the directory the rule names.Description
Type of Change
Related Issues
Fixes #
Changes Made
Testing
Test Coverage
zig build testand all tests passManual Testing
Platform Impact
Performance Impact
Breaking Changes
Documentation
Checklist
zig fmton my Zig codeScreenshots / Recordings
Additional Notes