镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

chore: ignore the Android fixtures' Gradle output - #544

Open
qcjxberin wants to merge 1 commit into
craft-native:mainfrom
qcjxberin:chore/ignore-android-fixture-build
Open

qcjxberin wants to merge 1 commit into
craft-native:mainfrom
qcjxberin:chore/ignore-android-fixture-build

Conversation

@qcjxberin

Copy link
Copy Markdown

.gitignore ignores the iOS slice fixture's build output but not the Android fixtures', so running any of their Gradle projects leaves build/ and .gradle/ sitting in git status as untracked.

Both are generated: build/ is the fixture's own output, and .gradle/ is Gradle's per-project cache, recreated on the next build. Neither belongs to whoever clones the repository.

The patterns are scoped to fixtures/*/ rather than naming each fixture, so a fixture added later is covered, while a build/ directory elsewhere in the tree is not swept up. Checked with git check-ignore:

  • packages/android/fixtures/vulkan-surface/build, .../build/outputs and .../.gradle are ignored, by lines 61 and 62.
  • packages/android/fixtures/vulkan-surface/build.gradle.kts is not ignored, which is the case that matters: the fixture's build script sits next to the directory the rule names.
  • The existing iOS rule at line 55 still matches.

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement
  • Documentation update
  • Refactoring (no functional changes)
  • CI/CD changes
  • Dependencies update

Related Issues

Fixes #

Changes Made

Testing

Test Coverage

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run zig build test and all tests pass

Manual Testing

  • Tested on macOS
  • Tested on Linux
  • Tested on Windows
  • Tested on iOS
  • Tested on Android

Platform Impact

  • All platforms
  • macOS only
  • Linux only
  • Windows only
  • iOS only
  • Android only
  • Desktop only (macOS, Linux, Windows)
  • Mobile only (iOS, Android)

Performance Impact

  • No performance impact
  • Improves performance
  • May impact performance (explain below)

Breaking Changes

  • This PR introduces breaking changes

Documentation

  • I have updated the documentation accordingly
  • This change requires no documentation update
  • Documentation update is tracked in a separate issue: #

Checklist

  • My code follows the project's style guidelines
  • I have run zig fmt on my Zig code
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have checked that this PR doesn't increase binary size significantly
  • I have read the CONTRIBUTING document

Screenshots / Recordings

Additional Notes


`.gitignore` ignores the iOS slice fixture's build output but not the Android
fixtures', so running any of their Gradle projects leaves `build/` and
`.gradle/` sitting in `git status` as untracked.

Both are generated: `build/` is the fixture's own output, and `.gradle/` is
Gradle's per-project cache, recreated on the next build. Neither belongs to
whoever clones the repository.

The patterns are scoped to `fixtures/*/` rather than naming each fixture, so a
fixture added later is covered, while a `build/` directory elsewhere in the
tree is not swept up. Checked with `git check-ignore`:

- `packages/android/fixtures/vulkan-surface/build`, `.../build/outputs` and
  `.../.gradle` are ignored, by lines 61 and 62.
- `packages/android/fixtures/vulkan-surface/build.gradle.kts` is not ignored,
  which is the case that matters: the fixture's build script sits next to the
  directory the rule names.
- The existing iOS rule at line 55 still matches.
Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants