Repository navigation
Label the Windows arm64 gem in the release download table - #283
Merged
Merged
Conversation
Motivation ---------- The tests workflow publishes an aarch64-mingw-ucrt gem, but DOCS_PLATFORM_LABELS has no entry for it. The download table printed by bin/publish-release.rb then shows the raw platform string as the label, and sorts the row after every labelled platform. Modifications ------------- aarch64-mingw-ucrt is labelled "Windows arm64" and ordered after "Windows x64". Results ------- Every gem platform the tests workflow publishes has a label in the download table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. The tests workflow publishes an
aarch64-mingw-ucrtgem.DOCS_PLATFORM_LABELSinbin/publish-release.rbhas no entry for it. The download table that the script prints shows the raw platform string for that row, and sorts it after every labelled platform.Change.
aarch64-mingw-ucrtis labelled "Windows arm64" and ordered after "Windows x64".