镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(EC-2188): limit release PR builds to linux amd64 - #3602

Merged
jsmid1 merged 1 commit into
conforma:mainfrom
jsmid1:EC-2188
Oct 20, 2026
Merged

jsmid1 merged 1 commit into
conforma:mainfrom
jsmid1:EC-2188

Conversation

@jsmid1

@jsmid1 jsmid1 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Use a release-specific pre-merge build-args file when generating release branch pipelines. Keep post-merge builds unmodified so they continue to build every supported platform.

Resolves: EC-2188

@jsmid1
jsmid1 requested a review from a team as a code owner October 13, 2026 10:53
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f1ab1c9a-cb21-440e-8697-1ce029df70c5
📥 Commits

Reviewing files that changed from the base of the PR and between d7152fd and a994b95.

📒 Files selected for processing (2)
  • hack/release-branch-pipeline-patch.sh
  • release-pre-merge-build-args.conf

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The release pipeline transformation now selects release-pre-merge-build-args.conf instead of removing the main pre-merge build-args filename. The release configuration sets BUILD_LIST to linux_amd64.

Changes: Release pre-merge build arguments

Layer / File(s) Summary
Configure and select release build arguments
release-pre-merge-build-args.conf, hack/release-branch-pipeline-patch.sh
The release configuration sets BUILD_LIST to linux_amd64. The pipeline transformation replaces the main pre-merge build-args filename with the release filename.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: dheerajodha, simonbaird

Merge Risk: ⚪ Minimal · up to a994b

Release pre-merge builds are limited to linux/amd64, while post-merge builds retain their existing platform coverage. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly states that release PR builds will be limited to Linux AMD64 and includes the related ticket.
Description check Passed The description explains what changes, why it changes, and links the related EC-2188 ticket. It covers the required template information despite not using the template headings.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Oct 13, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Risk Assessment: low (1/5)

Details

Minimal two-file XS configuration change with no security sensitivity, no CI workflow impact, no dependency changes, and a single known author - composite score 1.24 rounds to 1 (low).

Previous run

Risk Assessment: low (1/5)

Details

Two-file, three-line config-only change with small blast radius, no protected or security-sensitive paths, no CI or dependency modifications, a known author with minimal churn history, and a scope that precisely matches the stated issue; all signals converge at the lowest risk tier.

Previous run (2)

Risk Assessment: low (1/5)

Details

XS configuration-only change by a seasoned author limiting release builds to linux/amd64, touching no protected paths, security-sensitive files, or CI workflow definitions, with stable file history and a single prior fix commit yielding a composite near 1.

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Looks good to me

Previous run

Looks good to me

Previous run (2)

Looks good to me

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.54% <ø> (ø)
generative 12.25% <ø> (ø)
integration 23.55% <ø> (ø)
unit 72.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@st3penta st3penta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. this probably just needs a rebase to pass CI

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review October 19, 2026 13:15

Superseded by updated review

fullsend-ai-review[bot]

This comment was marked as outdated.

Use a release-specific pre-merge build-args file when generating release branch pipelines. Keep post-merge builds unmodified so they continue to build every supported platform.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: Jan Smid <jsmid@redhat.com>
@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review October 20, 2026 08:51

Superseded by updated review

@jsmid1
jsmid1 merged commit be22fc0 into conforma:main Oct 20, 2026
36 checks passed
@fullsend-ai-retro

Copy link
Copy Markdown

Retro on PR #3602 (fix(EC-2188): limit release PR builds to linux amd64). Clean workflow — nothing to propose.

What happened. Human-authored 2-file config change (one-line edit to hack/release-branch-pipeline-patch.sh plus a new single-line release-pre-merge-build-args.conf). The review agent (fullsend-ai-review) ran twice (initial and post-rebase), returned risk 1/5, and produced an empty v2 findings payload both times ("Looks good to me"). Two humans approved (st3penta, cuipinghuo); CI was green across Checks, CodeQL, codecov, Konflux, and CodeRabbit; the PR merged ~24h after the second human approval and a rebase.

Review quality. No human reviewer added inline change requests that the agent missed, and the agent did not flag anything a human later overruled. Low-complexity config change, correctly handled.

Rework rate. Zero iterations — one commit, one rebase, no fix cycle.

Autonomy readiness. For this class of change (small, additive release-pipeline config under hack/ with no code-path impact) the review agent matched the human reviewers; worth noting as one data point in the broader autonomy picture tracked by issues like #3508.

Existing-issue check. Related open retro-filed issues were reviewed and no new proposal is warranted:

Dispatch repo confirmed as fullsend-ai/fullsend @ ea66a0a1; agents repo confirmed as fullsend-ai/agents @ ce2eedd0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/low PR risk: low size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants