镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content
This repository was archived by the owner on Mar 27, 2019. It is now read-only.
This repository was archived by the owner on Mar 27, 2019. It is now read-only.

ugly "outdated" logs #612

Open
Open

Description

@stephenmathieson

imo, this is horrible:

$ node_modules/.bin/component-build 

  outdated name of a dependency : please update: "component/search.js" -> "componentjs/search.js"
   installed : yields/k@0.6.1 in 465ms
   installed : component/top@0.0.2 in 570ms
   installed : component/spinner@1.0.0 in 132ms

  [ ... ]

why not:

  warning: outdated dependency name; please update "component/search.js" -> "componentjs/search.js"

... or something?

Activity

  1. netpoetica commented on Nov 24, 2014

    @netpoetica

    I agree with this, but I think we might want to consider this as part of a more major log output overhaul, because I've seen a lot of logs like this.

  2. timaschew commented on Dec 7, 2014

    @timaschew
    Member

    have you some other examples?
    what exactly is ugly? that there is a missing warning prefix? or the wording?

  3. netpoetica commented on Dec 7, 2014

    @netpoetica

    @timaschew I think for me it's some of the sentence particles using arbitrary punctuation, in combination with all-lowercase words. I don't think the logs are awful, they're just not super-polished.

    For example, outdated name of a dependency : please update: is just strange use of the colon twice.

    A clear structure like

    LOG_LEVEL + TITLE + ":" + MESSAGE
    
    Warning - Outdated Dependencies: Please update "component/search.js" to "componentjs/search.js"
    
    // or
    
    Warning: Outdated Dependencies
    Please update "component/search.js" to "componentjs/search.js"
    
    // or
    Warning -> Outdated Dependencies: Please update "component/search.js" to "componentjs/search.js"
    

    Would be good to hear from @stephenmathieson for detail about possible improvements.

  4. stephenmathieson commented on Dec 7, 2014

    @stephenmathieson
    ContributorAuthor

    keep the left side of the : short and simple. for example: warning : ... (as suggested in the OP).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions