Ownership of find-node-modules #863

Activity

1. LinusU commented on Nov 23, 2021

   

   LinusU

   on Nov 23, 2021

   Last edited by LinusU

   Contributor

   More actions

   Looking at our code, we are actually just grabbing the first match:

   cz-cli/src/commitizen/adapter.js

   Lines 94 to 110 in 12442c1

   	/**
   	* Gets the nearest npm_modules directory
   	*/
   	function getNearestNodeModulesDirectory (options) {
   	// Get the nearest node_modules directories to the current working directory
   	let nodeModulesDirectories = findNodeModules(options);
   	// Make sure we find a node_modules folder
   	/* istanbul ignore else */
   	if (nodeModulesDirectories && nodeModulesDirectories.length > 0) {
   	return nodeModulesDirectories[0];
   	} else {
   	console.error(`Error: Could not locate node_modules in your project's root directory. Did you forget to npm init or npm install?`)
   	}
   	}

   So the best for cz-cli would be to just call findup-sync directly (or potentially find-up which seems to be more popular).