Parsing issues when option has separator attribute and when empty value provided... fails #420

Activity

1. lobster2012-user commented on Apr 14, 2019

   

   lobster2012-user

   on Apr 14, 2019

   More actions

   my fix

   public static IEnumerable<Token> Partition(
               IEnumerable<Token> tokens,
               Func<string, Maybe<TypeDescriptor>> typeLookup)
           {
               return from tseq in tokens.Pairwise(
                   (f, s) =>
                           f.IsName() /*&& s.IsValue() fix*/

   public static Result<IEnumerable<Token>, Error> ExplodeOptionList(
               Result<IEnumerable<Token>, Error> tokenizerResult,
               Func<string, Maybe<char>> optionSequenceWithSeparatorLookup)
           {
               var tokens = tokenizerResult.SucceededWith().Memorize();
   
               var replaces = tokens.Select((t, i) =>
                   optionSequenceWithSeparatorLookup(t.Text)
                       .MapValueOrDefault(sep => Tuple.Create(i + 1, sep),
                           Tuple.Create(-1, '\0'))).SkipWhile(x => x.Item1 < 0).Memorize();
   
               var exploded = tokens.Select((t, i) =>
               {
                   return replaces.FirstOrDefault(x =>
                   {
                       return x.Item1 == i && t.IsValue();//fix
                   }).ToMaybe()
2. wo-roberts commented on Jul 28, 2020

   

   wo-roberts

   on Jul 28, 2020

   More actions

   Separately found and fixed this issue and happy to put a PR in if you're happy?
3. rmunn

   added a commit that references this issue on Aug 20, 2020

   Fix enumerable options grabbing too many values

   ...

   This issue will close once commit 47618e0 is merged into the 'master' branch.

   47618e0
4. rmunn commented on Aug 20, 2020

   

   rmunn

   on Aug 20, 2020

   Contributor

   More actions

   This will be fixed by #684 once it's merged in. (It would also be fixed by #672, but #672 misses a different bug in the same code, so #684's version of the fix is better).
5. ericnewton76

   closed this as completedin 47618e0on May 12, 2022