镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

feat: report actual IDE for session tracking - #1136

Merged
EhabY merged 3 commits into
mainfrom
feat/client-643-ide-session-tracking
Oct 7, 2026
Merged

EhabY merged 3 commits into
mainfrom
feat/client-643-ide-session-tracking

Conversation

@EhabY

@EhabY EhabY commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Report vscode.env.uriScheme verbatim through --usage-app and CODER_SSH_SESSION_TYPE when both CLI and server support custom session app names (2.38+).
  • Otherwise use vscode, including unreadable CLI versions, without changing unrelated compatibility fallbacks.
  • Pass SSH configuration inputs through one options object. Separate app-selection tests from real in-memory SSH configuration checks.

Implements CLIENT-643.

Validation

  • Latest revision: typecheck, lint, formatting, and diff checks passed.
  • Before the latest test/SSH-options simplification: 43 focused tests passed; extension/webview build passed earlier.
  • Test execution skipped for the latest revision at request. Full suite previously interrupted by workspace disconnection; live deployment attribution not verified.
Approved plan and compatibility decisions
  1. Gate customSessionAppNames in existing CLI/server feature sets at 2.38.0, retaining the existing development-build convention.
  2. Resolve one app name from both capabilities. Fall back conservatively if CLI probing fails while preserving unrelated server-version fallbacks.
  3. Pass SSH configuration through SshConfigOptions; use the same name for both reporting mechanisms. Leave vscodessh unchanged and normalize only on the server.
  4. Cover compatibility boundaries with a small table, CLI-probe failure separately, and generated SSH values with focused in-memory config tests. No editor-brand mapping or branching test matrix.

Keep both signals: the workspace-usage experiment uses CLI usage requests for counts when enabled, and agent stats when disabled. Its proposed removal (coder/coder#30206) remains a draft and retains the usage flag. The CLI/server gate does not guarantee the workspace agent has been upgraded.

Generated by Coder Agents on behalf of @EhabY.

@linear-code

linear-code Bot commented Oct 6, 2026

Copy link
Copy Markdown

CLIENT-643

Comment thread src/remote/remote.ts
@EhabY
EhabY merged commit a39a19e into main Oct 7, 2026
13 checks passed
@EhabY
EhabY deleted the feat/client-643-ide-session-tracking branch October 7, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants