Is there an existing issue for this?
OS/Web Information
Web Browser: Not relevant; parsing occurs when code-server starts.
Local OS: Not relevant.
Remote OS: Not captured; this report is based on the source code and the reproduction reported in PR #7914.
Remote Architecture: Not captured.
code-server --version: v4.141.0 is affected according to its source code; no local version output was captured.
Steps to Reproduce
- Add enable-remote-storage: false to config.yaml.
- Start code-server without a command-line override for this option.
- Observe that remote storage is enabled, as reported in PR #7914.
Expected
Remote storage remains disabled when the YAML value is false.
Actual
Remote storage is enabled. parseConfigFile() converts the entry to --enable-remote-storage=false, but the shared argument parser sets any boolean option it encounters to true without checking its value.
Logs
Screenshot/Video
No response
Does this bug reproduce in native VS Code?
This cannot be tested in native VS Code
Does this bug reproduce in VS Code web?
This cannot be tested in VS Code web
Does this bug reproduce in GitHub Codespaces?
This cannot be tested in GitHub Codespaces
Are you accessing code-server over a secure context?
Notes
This is a code-server config.yaml parsing issue, not specific to remote storage. Other options declared as booleans follow the same path. The command-line form --flag=false is also silently interpreted as true. See the YAML conversion and boolean parser. Regression tests should cover both true and false.
Is there an existing issue for this?
OS/Web Information
Web Browser: Not relevant; parsing occurs when code-server starts.
Local OS: Not relevant.
Remote OS: Not captured; this report is based on the source code and the reproduction reported in PR #7914.
Remote Architecture: Not captured.
code-server --version: v4.141.0 is affected according to its source code; no local version output was captured.
Steps to Reproduce
Expected
Remote storage remains disabled when the YAML value is false.
Actual
Remote storage is enabled. parseConfigFile() converts the entry to --enable-remote-storage=false, but the shared argument parser sets any boolean option it encounters to true without checking its value.
Logs
Screenshot/Video
No response
Does this bug reproduce in native VS Code?
This cannot be tested in native VS Code
Does this bug reproduce in VS Code web?
This cannot be tested in VS Code web
Does this bug reproduce in GitHub Codespaces?
This cannot be tested in GitHub Codespaces
Are you accessing code-server over a secure context?
Notes
This is a code-server config.yaml parsing issue, not specific to remote storage. Other options declared as booleans follow the same path. The command-line form --flag=false is also silently interpreted as true. See the YAML conversion and boolean parser. Regression tests should cover both true and false.