镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

docs: fix AngularJS setup example and compatibility guidance - #52

Open
arjxnt wants to merge 1 commit into
coatue-oss:masterfrom
arjxnt:docs/fix-angularjs-setup-example
Open

arjxnt wants to merge 1 commit into
coatue-oss:masterfrom
arjxnt:docs/fix-angularjs-setup-example

Conversation

@arjxnt

@arjxnt arjxnt commented Oct 7, 2026

Copy link
Copy Markdown

The README example recreates the AngularJS module after registering its injector run block, uses invalid template interpolation, and declares the same component constant twice. Correct the example so it creates the module once, preserves registrations, and uses distinct names for the Angular definition and React wrapper.

Document the AngularJS 1.5.0 minimum already declared in peer dependencies, explain bootstrap timing, and provide explicit module setup for the ngimport alternative.

Fixes #30.

Validation: executed both documented setup paths with the repository's wrapper implementation, AngularJS 1.5.0, React 16.2.0, and real ngimport 1.0.0 in jsdom. Initial rendering, prop updates, and unmount execution passed. This was a local verification harness, not a real-browser compatibility matrix. git diff --check passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimum version AngularJS version

1 participant