enter key not working on Termux (Android) #77

Activity

1. clue commented on Aug 30, 2018

   

   clue

   on Aug 30, 2018

   Owner

   More actions

   @pulketo Thanks for reporting!

   This sounds very similar to #66 which was believed to be a Mac issue only and should have been fixed with #73 recently. This has not been tagged yet, so maybe you can try checking one of the examples from the master branch? If this doesn't work, maybe you can try the instructions in #66 (comment)?
2. clue

   added

   bugSomething isn't workingSomething isn't working

   on Aug 31, 2018
3. clue commented on Aug 31, 2018

   

   clue

   on Aug 31, 2018

   Owner

   More actions

   Thanks for reporting, I've been able to reproduce this with Termux and can confirm there's indeed an issue in this library on some platforms (as previously discussed in #66). I've started working on this and will file a PR that addresses this ASAP 👍
4. clue

   added this to the v2.2.0 milestone on Aug 31, 2018
5. clue

   changed the title [-]enter key not working on termux (android[/-] [+]enter key not working on Termux (Android)[/+] on Aug 31, 2018
6. pulketo commented on Sep 1, 2018

   

   pulketo

   on Sep 1, 2018

   Last edited by pulketo

   Author

   More actions

   This is due that the enter key on android is mapped as "return key", so, you just have to add this special key ;)
   vendor/clue/stdio-react/src/Readline.php
   line 45
   $that = $this;
   $codes = array(
   "\n" => 'onKeyEnter',
   // added return key/android
   "\015" => 'onKeyEnter',
7. clue

   closed this as completedin #79on Sep 1, 2018
8. clue commented on Sep 1, 2018

   

   clue

   on Sep 1, 2018

   Owner

   More actions

   @pulketo Thank you, this should now be fixed via #79 which will be released soon-ish