Repository navigation
PHP 8.2 deprecation #35
Description
👋 Just discovered a deprecation using mq-react running on PHP 8.2.
Creation of dynamic property React\Promise\Deferred::$pending is deprecated in /var/www/vendor/clue/mq-react/src/Queue.php on line 432
Couple of ways to solve this:
- Add
#[AllowDynamicProperties]in reactphp/promise v2 branch. Fast but might not be what we want. - Add some sort of deferred/promise index in
Queue. Quite a bit of work but clean.
What do you think?
Reacted by Christian Lück
Activity
SimonFrings commentedon Dec 14, 2022
Hey @bartvanhoutte, good catch 👍
I think we can go a similar as @clue did in reactphp/http#459. As you said, it involves some work but seems to be the best way. I don't know when exactly we will get to implement this as we're currently working a lot on ReactPHP and the upcoming v3, but we also don't want to push this too far back because PHP 8.2 has already been released. If you want to give it a try we're always happy about PRs! 😉
[-]PHP 8.2 depration[/-][+]PHP 8.2 deprecation[/+]clue commentedon Jul 27, 2023
Closed via #43
@bartvanhoutte Thank you for reporting and the sparking this development with your initial PR! 👍
bartvanhoutte commentedon Jul 27, 2023
@clue 👍 Didn't follow up because I don't know how to squash commits or something like that 😅
clue commentedon Jul 27, 2023
@bartvanhoutte Don't worry, we're happy to help if you run into something like this next time. 👍